Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix analyzer errors #19238

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Fix analyzer errors #19238

merged 10 commits into from
Jan 16, 2025
+253 −240

Conversation

Youssef1313
Copy link
Member

GitHub Issue (If applicable): closes #

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Jan 15, 2025
@jeromelaban
Copy link
Member

jeromelaban commented Jan 15, 2025 •
edited
Loading

@Youssef1313 thanks. I wonder, I'm getting errors on master without those changes, should it break master?

@Youssef1313
Copy link
Member Author

@jeromelaban Yeah probably it affects master. After looking around for a while, I think the root cause could be that I updated MSTest to a newer version in one PR, and enabled analyzers in another PR that passed because it's built using an older version of MSTest.Analyzers.

@github-actions github-actions bot added the area/automation Categorizes an issue or PR as relevant to project automation label Jan 15, 2025
@jeromelaban
Copy link
Member

Thanks, I'll prioritize this PR then so we get this sorted out.

@jeromelaban
Copy link
Member

@Youssef1313:

/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Border.cs(637,21): error MSTEST0029: Public method 'Nested_Element_Tapped' should be a test method (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0029) [/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj::TargetFramework=net8.0-macos14.0]
/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Border.cs(676,21): error MSTEST0029: Public method 'Parent_DoubleTapped_When_Child_Has_Tapped' should be a test method (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0029) [/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj::TargetFramework=net8.0-macos14.0]

@jeromelaban
Copy link
Member

@Youssef1313 Some more:

/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Tests/Windows_UI_StartScreen/Given_JumpListItem.cs(70,4): error MSTEST0037: Use 'Assert.IsNull' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj::TargetFramework=net8.0-android]
/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Tests/Windows_UI_StartScreen/Given_JumpListItem.cs(71,4): error MSTEST0037: Use 'Assert.IsFalse' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj::TargetFramework=net8.0-android]
/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Tests/Windows_UI_StartScreen/Given_JumpListItem.cs(96,4): error MSTEST0037: Use 'Assert.IsNull' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj::TargetFramework=net8.0-android]
/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/grid/GridIntegrationTests.cs(567,21): error MSTEST0029: Public method 'CanZeroWeightedCellsShrinkToZeroSize' should be a test method (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0029) [/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj::TargetFramework=net8.0-android]
/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Tests/Microsoft_UI_Xaml_Controls/Given_NavigationView.cs(71,5): error MSTEST0037: Use 'Assert.IsFalse' instead of 'Assert.AreEqual' (https://learn.microsoft.com/dotnet/core/testing/mstest-analyzers/mstest0037) [/Users/runner/work/1/s/src/Uno.UI.RuntimeTests/Uno.UI.RuntimeTests.netcoremobile.csproj::TargetFramework=net8.0-android]

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19238/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19238/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19238/index.html

@jeromelaban jeromelaban enabled auto-merge January 15, 2025 22:37
@unodevops
Copy link
Contributor

⚠️⚠️ The build 152187 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19238/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19238/index.html

@jeromelaban jeromelaban disabled auto-merge January 16, 2025 03:28
@jeromelaban jeromelaban merged commit 67e92ab into unoplatform:master Jan 16, 2025
110 of 113 checks passed
@Youssef1313 Youssef1313 deleted the fix-analyzer-errors branch January 16, 2025 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban jeromelaban approved these changes

@dr1rrb dr1rrb dr1rrb approved these changes

@ajpinedam ajpinedam ajpinedam approved these changes

Assignees
No one assigned
Labels
area/automation Categorizes an issue or PR as relevant to project automation area/skia ✏️ Categorizes an issue or PR as relevant to Skia
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Youssef1313 @jeromelaban @unodevops @ajpinedam @dr1rrb