chore: Fix more errors

unoplatform · Jan 15, 2025 · ab80188 · ab80188
1 parent f502fff
commit ab80188
Show file tree

Hide file tree

Showing 8 changed files with 16 additions and 9 deletions.
diff --git a/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/ItemTemplateTests.cs b/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/ItemTemplateTests.cs
@@ -542,7 +542,7 @@ await RunOnUIThread.ExecuteAsync(async () =>
 			});
 		}
 
-		public async Task ValidateTemplateSwitchingRefreshesElements(Layout layout)
+		private async Task ValidateTemplateSwitchingRefreshesElements(Layout layout)
 		{
 			var dataTemplate1 = (DataTemplate)XamlReader.Load(
 					 @"<DataTemplate  xmlns='http://schemas.microsoft.com/winfx/2006/xaml/presentation'>

diff --git a/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/RecyclePoolTests.cs b/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/RecyclePoolTests.cs
@@ -32,7 +32,7 @@ namespace Microsoft.UI.Xaml.Tests.MUXControls.ApiTests.RepeaterTests
 	[TestClass]
 	public class RecyclePoolTests : MUXApiTestBase
 	{
-
+		[TestMethod]
 		public void ValidateElementsHaveCorrectKeys()
 		{
 			RunOnUIThread.Execute(() =>

diff --git a/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/ViewManagerTests.cs b/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/ViewManagerTests.cs
@@ -90,7 +90,8 @@ public void CanQueryElementFactory()
 			});
 		}
 
-		// [TestMethod] Issue #1018
+		[TestMethod] // Issue #1018
+		[Ignore]
 		public async Task CanPinFocusedElements()
 		{
 			// Setup a grouped repeater scenario with two groups each containing two items.
@@ -191,7 +192,8 @@ public async Task CanPinFocusedElements()
 			});
 		}
 
-		// [TestMethod] Issue 1018
+		[TestMethod] // Issue 1018
+		[Ignore]
 		public async Task CanReuseElementsDuringUniqueIdReset()
 		{
 			var data = new WinRTCollection(Enumerable.Range(0, 2).Select(i => string.Format("Item #{0}", i)));
@@ -678,7 +680,8 @@ public void ValidateDataContextGetsPropagated()
 			});
 		}
 
-		// [TestMethod] Issue 1018
+		[TestMethod] // Issue 1018
+		[Ignore]
 		public async Task ValidateFocusMoveOnElementCleared()
 		{
 			CustomItemsSource dataSource = null;
@@ -721,7 +724,8 @@ await SharedHelpers.RunActionsWithWait(
 				});
 		}
 
-		// [TestMethod] Issue 1018
+		[TestMethod] // Issue 1018
+		[Ignore]
 		public async Task ValidateFocusMoveOnElementClearedWithUniqueIds()
 		{
 			CustomItemsSource dataSource = null;

diff --git a/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/ViewportTests.cs b/src/Uno.UI.RuntimeTests/MUX/Microsoft_UI_Xaml_Controls/Repeater/ViewportTests.cs
@@ -109,7 +109,8 @@ public void ValidateNoScrollingSurfaceScenario()
 			});
 		}
 
-		// [TestMethod] Temporarily disabled for bug 18866003
+		[TestMethod] // Temporarily disabled for bug 18866003
+		[Ignore]
 		public async Task ValidateItemsRepeaterScrollHostScenario()
 		{
 			var realizationRects = new List<Rect>();

diff --git a/src/Uno.UI.RuntimeTests/Tests/TemplatedParent/TemplatedParentTests.cs b/src/Uno.UI.RuntimeTests/Tests/TemplatedParent/TemplatedParentTests.cs
@@ -218,6 +218,7 @@ public async Task ItemsControl_HeaderFooter_NoTP_DynamicXaml()
 		await ItemsControl_HeaderFooter_NoTP(sut, sut);
 	}
 
+	[TestMethod]
 	public async Task ItemsControl_HeaderFooter_NoTP(FrameworkElement setup, ItemsControl sut)
 	{
 		await UITestHelper.Load(setup, x => x.IsLoaded);

diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Frame.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_Frame.cs
@@ -60,7 +60,7 @@ public Task When_Page_Loaded_Navigates_Without_Yield() =>
 	public Task When_Page_Loaded_Navigates_With_Yield() =>
 		When_Page_Loaded_Navigates_Inner(true);
 
-	public async Task When_Page_Loaded_Navigates_Inner(bool yield)
+	private async Task When_Page_Loaded_Navigates_Inner(bool yield)
 	{
 		var frame = new Frame();
 		TestServices.WindowHelper.WindowContent = frame;

diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FrameworkTemplatePool.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_FrameworkTemplatePool.cs
@@ -201,7 +201,7 @@ void AssertEditorContents()
 			Assert.IsTrue(vm.Editors.All(e => !string.IsNullOrEmpty(e.Text)));
 			Assert.IsTrue(vm.Editors.All(e => e.IsChecked));
 			Assert.IsTrue(vm.Editors.All(e => e.IsOn));
-			Assert.IsTrue(!string.IsNullOrEmpty(textBox.Text));
+			Assert.IsFalse(string.IsNullOrEmpty(textBox.Text));
 			Assert.IsTrue(checkBox.IsChecked);
 			Assert.IsTrue(toggleSwitch.IsOn);
 			Assert.AreEqual(vm.CurrentEditor.IsChecked, checkBox.IsChecked);

diff --git a/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ListViewBase.cs b/src/Uno.UI.RuntimeTests/Tests/Windows_UI_Xaml_Controls/Given_ListViewBase.cs
@@ -610,6 +610,7 @@ public async Task MultipleItemsSelected()
 			Assert.AreEqual(list.SelectedItems[1], child3);
 		}
 
+		[TestMethod]
 		public async Task NoItemSelectedMultiple()
 		{
 			var child1 = new ListViewItem