Skip to content

Commit

Permalink
Bump rc/components to improve module naming
Browse files Browse the repository at this point in the history
  • Loading branch information
jerryz123 committed Jun 26, 2024
1 parent b8bcf07 commit 760957a
Show file tree
Hide file tree
Showing 12 changed files with 16 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ class WithPLLSelectorDividerClockGenerator(enable: Boolean = true) extends Overr
val clockSelector = system.prci_ctrl_domain { LazyModule(new TLClockSelector(baseAddress + 0x30000, tlbus.beatBytes, enable=enable)) }
val pllCtrl = system.prci_ctrl_domain { LazyModule(new FakePLLCtrl (baseAddress + 0x40000, tlbus.beatBytes)) }

clockDivider.tlNode := system.prci_ctrl_domain { TLFragmenter(tlbus.beatBytes, tlbus.blockBytes) := system.prci_ctrl_bus.get }
clockSelector.tlNode := system.prci_ctrl_domain { TLFragmenter(tlbus.beatBytes, tlbus.blockBytes) := system.prci_ctrl_bus.get }
pllCtrl.tlNode := system.prci_ctrl_domain { TLFragmenter(tlbus.beatBytes, tlbus.blockBytes) := system.prci_ctrl_bus.get }
clockDivider.tlNode := system.prci_ctrl_domain { TLFragmenter(tlbus, Some("ClockDivider")) := system.prci_ctrl_bus.get }
clockSelector.tlNode := system.prci_ctrl_domain { TLFragmenter(tlbus, Some("ClockSelector")) := system.prci_ctrl_bus.get }
pllCtrl.tlNode := system.prci_ctrl_domain { TLFragmenter(tlbus, Some("PLLCtrl")) := system.prci_ctrl_bus.get }

system.chiptopClockGroupsNode := clockDivider.clockNode := clockSelector.clockNode

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ class ClockGroupParameterModifier(
sinkFn: ClockGroupSinkParameters => ClockGroupSinkParameters = { s => s })(
implicit p: Parameters, v: ValName) extends LazyModule {
val node = ClockGroupAdapterNode(sourceFn, sinkFn)
override def shouldBeInlined = true
lazy val module = new LazyRawModuleImp(this) {
(node.out zip node.in).map { case ((o, _), (i, _)) =>
(o.member.data zip i.member.data).foreach { case (oD, iD) => oD := iD }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ trait HasChipyardPRCI { this: BaseSubsystem with InstantiatesHierarchicalElement
val prci_ctrl_domain = tlbus.generateSynchronousDomain("ChipyardPRCICtrl")
.suggestName("chipyard_prcictrl_domain")

val prci_ctrl_bus = Option.when(prciParams.generatePRCIXBar) { prci_ctrl_domain { TLXbar() } }
val prci_ctrl_bus = Option.when(prciParams.generatePRCIXBar) { prci_ctrl_domain { TLXbar(nameSuffix = Some("prcibus")) } }
prci_ctrl_bus.foreach(xbar => tlbus.coupleTo("prci_ctrl") { (xbar
:= TLFIFOFixer(TLFIFOFixer.all)
:= TLBuffer()
Expand Down Expand Up @@ -71,13 +71,13 @@ trait HasChipyardPRCI { this: BaseSubsystem with InstantiatesHierarchicalElement
}
val tileClockGater = Option.when(prciParams.enableTileClockGating) { prci_ctrl_domain {
val clock_gater = LazyModule(new TileClockGater(prciParams.baseAddress + 0x00000, tlbus.beatBytes))
clock_gater.tlNode := TLFragmenter(tlbus.beatBytes, tlbus.blockBytes) := prci_ctrl_bus.get
clock_gater.tlNode := TLFragmenter(tlbus.beatBytes, tlbus.blockBytes, nameSuffix = Some("TileClockGater")) := prci_ctrl_bus.get
clock_gater
} }
val tileResetSetter = Option.when(prciParams.enableTileResetSetting) { prci_ctrl_domain {
val reset_setter = LazyModule(new TileResetSetter(prciParams.baseAddress + 0x10000, tlbus.beatBytes,
tile_prci_domains.map(_._2.tile_reset_domain.clockNode.portParams(0).name.get).toSeq, Nil))
reset_setter.tlNode := TLFragmenter(tlbus.beatBytes, tlbus.blockBytes) := prci_ctrl_bus.get
reset_setter.tlNode := TLFragmenter(tlbus.beatBytes, tlbus.blockBytes, nameSuffix = Some("TileResetSetter")) := prci_ctrl_bus.get
reset_setter
} }

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,6 @@ class AbstractConfig extends Config(
new freechips.rocketchip.subsystem.WithCoherentBusTopology ++ /** hierarchical buses including sbus/mbus/pbus/fbus/cbus/l2 */
new chipyard.config.WithSV48IfPossible ++ /** use sv48 if possible */


// ================================================
// Set up power, reset and clocking
// ================================================
Expand Down
2 changes: 2 additions & 0 deletions generators/chipyard/src/main/scala/config/ChipConfigs.scala
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import testchipip.soc.{OBUS}

// A simple config demonstrating how to set up a basic chip in Chipyard
class ChipLikeRocketConfig extends Config(
new freechips.rocketchip.subsystem.WithoutTLMonitors ++

//==================================
// Set up TestHarness
//==================================
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,9 @@ class NoCoresConfig extends Config(
new chipyard.config.WithNoUART ++
new chipyard.config.WithNoTileClockGaters ++
new chipyard.config.WithNoTileResetSetters ++
new chipyard.config.WithNoBusErrorDevices ++
new chipyard.config.WithNoDebug ++
new chipyard.config.WithNoPLIC ++
new chipyard.config.WithNoBusErrorDevices ++
new chipyard.config.AbstractConfig)

// A config that uses a empty chiptop module with no rocket-chip soc components
Expand Down
2 changes: 1 addition & 1 deletion generators/diplomacy
2 changes: 1 addition & 1 deletion generators/rocket-chip
Submodule rocket-chip updated 36 files
+1 −1 src/main/scala/devices/debug/Debug.scala
+1 −1 src/main/scala/devices/debug/Periphery.scala
+1 −1 src/main/scala/devices/tilelink/BootROM.scala
+1 −1 src/main/scala/devices/tilelink/CLINT.scala
+1 −1 src/main/scala/devices/tilelink/Plic.scala
+9 −0 src/main/scala/interrupts/Crossing.scala
+2 −0 src/main/scala/interrupts/Xbar.scala
+2 −0 src/main/scala/jtag/JtagShifter.scala
+2 −1 src/main/scala/prci/ClockGroup.scala
+1 −1 src/main/scala/prci/ResetStretcher.scala
+7 −1 src/main/scala/regmapper/RegMapper.scala
+2 −2 src/main/scala/rocket/DCache.scala
+2 −2 src/main/scala/rocket/ICache.scala
+1 −0 src/main/scala/rocket/PMP.scala
+4 −2 src/main/scala/rocket/RocketCore.scala
+1 −0 src/main/scala/rocket/TLB.scala
+1 −0 src/main/scala/subsystem/Cluster.scala
+2 −0 src/main/scala/subsystem/HasHierarchicalElements.scala
+1 −1 src/main/scala/subsystem/HasTiles.scala
+2 −2 src/main/scala/subsystem/HierarchicalElement.scala
+1 −1 src/main/scala/subsystem/MemoryBus.scala
+5 −4 src/main/scala/subsystem/PeripheryBus.scala
+1 −1 src/main/scala/subsystem/SystemBus.scala
+2 −0 src/main/scala/tile/FPU.scala
+2 −0 src/main/scala/tilelink/AsyncCrossing.scala
+4 −2 src/main/scala/tilelink/AtomicAutomata.scala
+2 −0 src/main/scala/tilelink/Buffer.scala
+5 −0 src/main/scala/tilelink/Bundles.scala
+3 −3 src/main/scala/tilelink/BusWrapper.scala
+8 −4 src/main/scala/tilelink/Fragmenter.scala
+3 −0 src/main/scala/tilelink/Parameters.scala
+2 −0 src/main/scala/tilelink/WidthWidget.scala
+5 −4 src/main/scala/tilelink/Xbar.scala
+4 −0 src/main/scala/util/AsyncQueue.scala
+1 −0 src/main/scala/util/Repeater.scala
+1 −1 src/main/scala/util/package.scala
2 changes: 1 addition & 1 deletion generators/rocket-chip-blocks

0 comments on commit 760957a

Please sign in to comment.