chore: drop python<=3.7 support

[kloczek]

Checklist

• I acknowledge that all my contributions will be made under the project's license
• I have made a material change to the repo (functionality, testing, spelling, grammar)
• I have read the Contribution Guidelines and my PR follows them
• I have titled the PR appropriately
• I have updated my branch with the main branch
• I have added tests that prove my fix is effective or that my feature works
• I have added the necessary documentation about the functionality in the appropriate .md file
• I have added inline documentation to the code I modified

[tiwarishubham635]

Is this Python 3.7 has reached its EOL?

[tiwarishubham635]

I think you should also remove testing against python 3.7 here

[a-detiste]

Do you still want to support 3.7 ?

https://bugs.python.org/issue45028

[tiwarishubham635]

Do you still want to support 3.7 ?

https://bugs.python.org/issue45028

I mean we can remove it since its EOL, would need to remove it from test file as well

[tiwarishubham635]

As this is an extension of #781, it states:

According to https://endoflife.date/python python 3.7 is EOSed since 27 Jun 2023.
Filter all code over pyupgrade --py38.

However, since we want to maintain support for python>=3.8, shouldn't we use the flag --py38-plus?

[kloczek]

As this is an extension of #781, it states:

According to https://endoflife.date/python python 3.7 is EOSed since 27 Jun 2023.
Filter all code over pyupgrade --py38.

However, since we want to maintain support for python>=3.8, shouldn't we use the flag --py38-plus?

It is an mistake in commit comment.

$ pyupgrade --help
usage: pyupgrade [-h] [--exit-zero-even-if-changed] [--keep-percent-format] [--keep-mock] [--keep-runtime-typing] [--py3-plus] [--py36-plus] [--py37-plus] [--py38-plus] [--py39-plus]
                 [--py310-plus] [--py311-plus] [--py312-plus]
                 [filenames ...]

positional arguments:
  filenames

options:
  -h, --help            show this help message and exit
  --exit-zero-even-if-changed
  --keep-percent-format
  --keep-mock
  --keep-runtime-typing
  --py3-plus, --py3-only
  --py36-plus
  --py37-plus
  --py38-plus
  --py39-plus
  --py310-plus
  --py311-plus
  --py312-plus

[kloczek]

However, since we want to maintain support for python>=3.8, shouldn't we use the flag --py38-plus?

That is exact option which I've used 😋

[tiwarishubham635]

Cool. Please remove the python 3.7 from test file and then I can review.

[kloczek]

done

[tiwarishubham635]

Hey @kloczek! There are some files in rest folder that are auto generated. For those files to reflect this change, we need to make changes in our generator repo. I'll do the same and update it here. Thanks!

[kloczek]

OK. No problem. I understand 😄
Just cancel this PR and do how it should be done 😋

[tiwarishubham635]

I have created an internal ticket for this issue to be fixed. Thanks!

[tiwarishubham635]

Closing this as not planned