Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use new unittest.mock from standard library #782

Closed
wants to merge 0 commits into from

Conversation

a-detiste
Copy link

@a-detiste a-detiste commented Mar 21, 2024

https://github.com/testing-cabal/mock

"mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards."

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • [ x I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@tiwarishubham635
Copy link
Contributor

I see some error here, can you check this?

@a-detiste
Copy link
Author

Please merge #783 first and I will rebase if this can't be done automagicaly with github

@a-detiste
Copy link
Author

So finally no #783 , I will trim this down

@tiwarishubham635
Copy link
Contributor

So there will be some changes in this repo and some in generator repo. We can use #783 for this repo's changes.

@tiwarishubham635
Copy link
Contributor

@a-detiste do you want to continue working on it?

@a-detiste
Copy link
Author

Yes I can

@a-detiste
Copy link
Author

Well it's done for me... only merge needed

@tiwarishubham635
Copy link
Contributor

Please check the failing tests. if mock is part of python since 3.3 then it should work fine with 3.7 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants