Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: added null check accountSid #617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: added null check accountSid #617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5135f82
chore: added null check accountSid
sbansla Sep 27, 2024
181c566
chore: added null check for path accountSid
sbansla Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/api/v2010/AccountCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
4 changes: 4 additions & 0 deletions examples/java/src/main/java/com/twilio/rest/api/v2010/AccountDeleter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.converter.Converter;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
Expand Down Expand Up @@ -61,6 +62,9 @@ public boolean delete(final TwilioRestClient client) {
String path = "/2010-04-01/Accounts/{Sid}.json";

this.pathSid = this.pathSid == null ? client.getAccountSid() : this.pathSid;
if (this.pathSid == null) {
throw new InvalidRequestException("pathSid can not be null");
}
path = path.replace("{"+"Sid"+"}", this.pathSid.toString());

Request request = new Request(
Expand Down
4 changes: 4 additions & 0 deletions examples/java/src/main/java/com/twilio/rest/api/v2010/AccountFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down Expand Up @@ -62,6 +63,9 @@ public Account fetch(final TwilioRestClient client) {
String path = "/2010-04-01/Accounts/{Sid}.json";

this.pathSid = this.pathSid == null ? client.getAccountSid() : this.pathSid;
if (this.pathSid == null) {
throw new InvalidRequestException("pathSid can not be null");
}
path = path.replace("{"+"Sid"+"}", this.pathSid.toString());

Request request = new Request(
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/api/v2010/AccountReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
4 changes: 4 additions & 0 deletions examples/java/src/main/java/com/twilio/rest/api/v2010/AccountUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down Expand Up @@ -75,6 +76,9 @@ public Account update(final TwilioRestClient client){
String path = "/2010-04-01/Accounts/{Sid}.json";

this.pathSid = this.pathSid == null ? client.getAccountSid() : this.pathSid;
if (this.pathSid == null) {
throw new InvalidRequestException("pathSid can not be null");
}
path = path.replace("{"+"Sid"+"}", this.pathSid.toString());
path = path.replace("{"+"Status"+"}", this.status.toString());

Expand Down
4 changes: 4 additions & 0 deletions examples/java/src/main/java/com/twilio/rest/api/v2010/account/CallCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down Expand Up @@ -102,6 +103,9 @@ public Call create(final TwilioRestClient client){
String path = "/2010-04-01/Accounts/{AccountSid}/Calls.json";

this.pathAccountSid = this.pathAccountSid == null ? client.getAccountSid() : this.pathAccountSid;
if (this.pathAccountSid == null) {
throw new InvalidRequestException("pathAccountSid can not be null");
}
path = path.replace("{"+"AccountSid"+"}", this.pathAccountSid.toString());
path = path.replace("{"+"RequiredStringProperty"+"}", this.requiredStringProperty.toString());
path = path.replace("{"+"TestMethod"+"}", this.testMethod.toString());
Expand Down
4 changes: 4 additions & 0 deletions examples/java/src/main/java/com/twilio/rest/api/v2010/account/CallDeleter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.converter.Converter;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
Expand Down Expand Up @@ -64,6 +65,9 @@ public boolean delete(final TwilioRestClient client) {
String path = "/2010-04-01/Accounts/{AccountSid}/Calls/{TestInteger}.json";

this.pathAccountSid = this.pathAccountSid == null ? client.getAccountSid() : this.pathAccountSid;
if (this.pathAccountSid == null) {
throw new InvalidRequestException("pathAccountSid can not be null");
}
path = path.replace("{"+"AccountSid"+"}", this.pathAccountSid.toString());
path = path.replace("{"+"TestInteger"+"}", this.pathTestInteger.toString());

Expand Down
4 changes: 4 additions & 0 deletions examples/java/src/main/java/com/twilio/rest/api/v2010/account/CallFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down Expand Up @@ -65,6 +66,9 @@ public Call fetch(final TwilioRestClient client) {
String path = "/2010-04-01/Accounts/{AccountSid}/Calls/{TestInteger}.json";

this.pathAccountSid = this.pathAccountSid == null ? client.getAccountSid() : this.pathAccountSid;
if (this.pathAccountSid == null) {
throw new InvalidRequestException("pathAccountSid can not be null");
}
path = path.replace("{"+"AccountSid"+"}", this.pathAccountSid.toString());
path = path.replace("{"+"TestInteger"+"}", this.pathTestInteger.toString());

Expand Down
4 changes: 4 additions & 0 deletions ...java/src/main/java/com/twilio/rest/api/v2010/account/call/FeedbackCallSummaryUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down Expand Up @@ -85,6 +86,9 @@ public FeedbackCallSummary update(final TwilioRestClient client){
String path = "/2010-04-01/Accounts/{AccountSid}/Calls/Feedback/Summary/{Sid}.json";

this.pathAccountSid = this.pathAccountSid == null ? client.getAccountSid() : this.pathAccountSid;
if (this.pathAccountSid == null) {
throw new InvalidRequestException("pathAccountSid can not be null");
}
path = path.replace("{"+"AccountSid"+"}", this.pathAccountSid.toString());
path = path.replace("{"+"Sid"+"}", this.pathSid.toString());
path = path.replace("{"+"EndDate"+"}", this.endDate.toString());
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/flexapi/v1/CallUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/flexapi/v1/credential/AwsDeleter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.converter.Converter;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/flexapi/v1/credential/AwsFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/flexapi/v1/credential/AwsReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/flexapi/v1/credential/AwsUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/flexapi/v1/credential/NewCredentialsCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/flexapi/v1/credential/aws/HistoryFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/previewiam/organizations/UserCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/previewiam/organizations/UserDeleter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.converter.Converter;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/previewiam/organizations/UserFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/previewiam/organizations/UserReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/previewiam/organizations/UserUpdater.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/previewiam/v1/TokenCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/versionless/deployedDevices/FleetCreator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/versionless/deployedDevices/FleetFetcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions examples/java/src/main/java/com/twilio/rest/versionless/understand/AssistantReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/twilio-java/creator.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/twilio-java/deleter.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import com.twilio.constant.EnumConstants;
import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.converter.Converter;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/twilio-java/fetcher.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
3 changes: 3 additions & 0 deletions src/main/resources/twilio-java/generate_uri.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
{{#allParams}}
{{#vendorExtensions.x-is-account-sid}}
this.{{paramName}} = this.{{paramName}} == null ? client.getAccountSid() : this.{{paramName}};
if (this.{{paramName}} == null) {
throw new InvalidRequestException("{{paramName}} can not be null");
}
path = path.replace("{"+"{{baseName}}"+"}", this.{{paramName}}.toString());
{{/vendorExtensions.x-is-account-sid}}
{{/allParams}}
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/twilio-java/reader.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
1 change: 1 addition & 0 deletions src/main/resources/twilio-java/updater.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import com.twilio.exception.ApiConnectionException;
import com.twilio.converter.PrefixedCollapsibleMap;
import com.twilio.converter.Converter;
import com.twilio.exception.ApiException;
import com.twilio.exception.InvalidRequestException;
import com.twilio.exception.RestException;
import com.twilio.http.HttpMethod;
import com.twilio.http.Response;
Expand Down
Loading