Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added null check accountSid #617

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

sbansla
Copy link
Contributor

@sbansla sbansla commented Sep 27, 2024

Fixes

This change is for introduction of OAuth for public APIs.
There are 2 types of APIs: v2010 and non v2010
v2010
This requires AccountSid as a part of path parameter but it not mandatory to be passed as a part of an API, means it can be initialised during credential initialisation.
Twilio.init(account_sid, auth_token);
But as a part of OAuth, We are not setting it to any value, thus null pointer exception can occur, to avoid that exception has been added in v2010 APIs.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • Run make test-docker
  • Verify affected language:
    • Generate twilio-go from our OpenAPI specification using the build_twilio_go.py using python examples/build_twilio_go.py path/to/twilio-oai/spec/yaml path/to/twilio-go and inspect the diff
    • Run make test in twilio-go
    • Create a pull request in twilio-go
    • Provide a link below to the pull request
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please create a GitHub Issue in this repository.

Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Failed Quality Gate failed for 'twilio-oai-generator-java'

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 27, 2024

Copy link

sonarcloud bot commented Sep 27, 2024

Quality Gate Passed Quality Gate passed for 'twilio-oai-generator-python'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Sep 27, 2024

@sbansla sbansla marked this pull request as ready for review September 27, 2024 16:09
Copy link
Contributor

@AsabuHere AsabuHere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants