New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: flaky test in datetime because compare pre-init now. #652

Closed

sonhmai wants to merge 1 commit into tursodatabase:main from sonhmai:fix/flaky-time-test

Contributor

sonhmai commented Jan 11, 2025 •

edited

Loading

Removed flaky test that happens sometimes when the CI runner is a bit slow e.g. in https://github.com/tursodatabase/limbo/actions/runs/12706265753/job/35418879041?pr=643

'now' is covered in other test so it should be fine. it is a problem in time test, for date not so much.

for example it is covered in:

https://github.com/tursodatabase/limbo/blob/bcc85c37a0febdf5c3f29127029fe10c9906867d/core/vdbe/datetime.rs#L1434C5-L1446C6


          fix: flaky test in datetime because compare pre-init now.

46eba6c

'now' is covered in other test so it should be fine.

penberg closed this in

8769bf8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet