Skip to content

Commit

Permalink
Merge 'fix: flaky test in datetime because compare pre-init now.' fro…
Browse files Browse the repository at this point in the history
…m Sonny

Removed flaky test that happens sometimes when the CI runner is a bit
slow e.g. in https://github.com/tursodatabase/limbo/actions/runs/1270626
5753/job/35418879041?pr=643
'now' is covered in other test so it should be fine. it is a problem in
time test, for date not so much.
for example it is covered in:
https://github.com/tursodatabase/limbo/blob/bcc85c37a0febdf5c3f29127029f
e10c9906867d/core/vdbe/datetime.rs#L1434C5-L1446C6

Closes #652
  • Loading branch information
penberg committed Jan 13, 2025
2 parents fa6a9ed + 46eba6c commit 8769bf8
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions core/vdbe/datetime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -884,8 +884,6 @@ mod tests {

#[test]
fn test_valid_get_time_from_datetime_value() {
let now = chrono::Local::now().to_utc().format("%H:%M:%S").to_string();

let test_time_str = "22:30:45";
let prev_time_str = "20:30:45";
let next_time_str = "03:30:45";
Expand Down Expand Up @@ -1049,8 +1047,6 @@ mod tests {
OwnedValue::build_text(Rc::new("22:30:45.123Z".to_string())),
test_time_str,
),
// Test Format 11: 'now'
(OwnedValue::build_text(Rc::new("now".to_string())), &now),
// Format 12: DDDDDDDDDD (Julian date as float or integer)
(OwnedValue::Float(2460082.1), "14:24:00"),
(OwnedValue::Integer(2460082), "12:00:00"),
Expand Down

0 comments on commit 8769bf8

Please sign in to comment.