Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: custom log config files need to end in _log.json not just .json #1307

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Commits on Sep 13, 2024

  1. doc: custom log config files need to end in _log.json not just .json

    I struggled to find out why I couldn't get SQL queries to work on my otherwise functioning custom log file.
    
    When trying out another custom log file from a PR I realized that my file was called `postgresCustom.json` and all other log files were ending in `_log.json` (mine wasn't).
    
    When I added the magic `_log.json` SQL finally started working!
    
    Mentioning this in the docs is a good start. It would be even better if this was validated and logged in the debug logs.
    
    For example, I created the custom config via the regex101 importer like this:
    
    ```
    lnav -m regex101 import https://regex101.com/r/5CZxWI/1 postgresCustom
    ```
    
    The importer should have either complained that I must end the file name in `_log`, e.g. `postgresCustom_log`, or it should have simply appended that `_log` suffix.
    corneliusroemer authored Sep 13, 2024
    Configuration menu
    Copy the full SHA
    9756861 View commit details
    Browse the repository at this point in the history