doc: custom log config files need to end in _log.json
not just .json
#1307
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I struggled to find out why I couldn't get SQL queries to work on my otherwise functioning custom log file.
When trying out another custom log file from a PR I realized that my file was called
postgresCustom.json
and all other log files were ending in_log.json
(mine wasn't).When I added the magic
_log.json
SQL finally started working!Mentioning this in the docs is a good start. It would be even better if this was validated and logged in the debug logs.
For example, I created the custom config via the regex101 importer like this:
The importer should have either complained that I must end the file name in
_log
, e.g.postgresCustom_log
, or it should have simply appended that_log
suffix.