Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat conversation error as authentication failure #925

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Treat conversation error as authentication failure #925

merged 2 commits into from
Dec 19, 2024

Conversation

bjorn3
Copy link
Collaborator

@bjorn3 bjorn3 commented Dec 3, 2024

On FreeBSD PAM returns a conversation error when there is nowhere to read the password from.

test result: FAILED. 620 passed; 10 failed; 77 ignored; 0 measured; 0 filtered out; finished in 352.25s

error: test failed, to rerun pass `-p sudo-compliance-tests --lib`

Part of #869

@bjorn3 bjorn3 added the freebsd label Dec 3, 2024
@squell squell requested a review from rnijveld December 9, 2024 09:31
@bjorn3 bjorn3 force-pushed the freebsd_conversation_error branch from d3fc98f to cbf0296 Compare December 16, 2024 10:13
@squell squell force-pushed the freebsd_conversation_error branch from cbf0296 to 3bb5648 Compare December 16, 2024 12:45
@squell squell added C-pam PAM library test-framework non-compliant used to track failing compliance tests and removed test-framework labels Dec 18, 2024
@bjorn3 @squell
Treat conversation error as authentication failure
169fe60 
On FreeBSD PAM returns a conversation error when there is nowhere to
read the password from.
@squell squell force-pushed the freebsd_conversation_error branch from 3bb5648 to 169fe60 Compare December 19, 2024 00:14
@squell squell mentioned this pull request Dec 19, 2024
Merged
@rnijveld rnijveld merged commit 5df02e2 into trifectatechfoundation:main Dec 19, 2024
13 checks passed
@bjorn3 bjorn3 deleted the freebsd_conversation_error branch December 19, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rnijveld rnijveld rnijveld approved these changes

Assignees

@rnijveld rnijveld

Labels
C-pam PAM library freebsd non-compliant used to track failing compliance tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjorn3 @rnijveld @squell