Suggested changes #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjorn3
added a commit
that referenced
this pull request
Dec 19, 2024
…error occurred (#2)" This reverts commit fd3cfec. Turns out that this commit causes a fair amount of test failures on FreeBSD: ``` failures: ---- sudo::flag_list::credential_caching::flag_reset_timestamp stdout ---- thread 'sudo::flag_list::credential_caching::flag_reset_timestamp' panicked at sudo-compliance-tests/src/sudo/flag_list/credential_caching.rs:96:5: "sudo-rs: interactive authentication is required" did not contain "sudo: Authentication failed" note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace ---- sudo::pass_auth::tty::no_tty stdout ---- thread 'sudo::pass_auth::tty::no_tty' panicked at sudo-compliance-tests/src/sudo/pass_auth/tty.rs:64:5: "sudo-rs: interactive authentication is required" did not contain "Maximum 3 incorrect authentication attempts" ---- sudo::sudoers::timestamp_timeout::zero_always_prompts_for_password stdout ---- thread 'sudo::sudoers::timestamp_timeout::zero_always_prompts_for_password' panicked at sudo-compliance-tests/src/sudo/sudoers/timestamp_timeout.rs:84:5: "[sudo: authenticate] Password:sudo-rs: interactive authentication is required" did not contain "incorrect authentication attempt" ---- sudo::sudoers::timestamp_timeout::nonzero stdout ---- thread 'sudo::sudoers::timestamp_timeout::nonzero' panicked at sudo-compliance-tests/src/sudo/sudoers/timestamp_timeout.rs:54:5: "[sudo: authenticate] Password:sudo-rs: interactive authentication is required" did not contain "incorrect authentication attempt" ---- sudo::timestamp::by_default_credential_caching_is_local stdout ---- thread 'sudo::timestamp::by_default_credential_caching_is_local' panicked at sudo-compliance-tests/src/sudo/timestamp.rs:51:5: "sudo-rs: interactive authentication is required" did not contain "incorrect authentication attempt" ---- sudo::timestamp::remove::also_works_locally stdout ---- thread 'sudo::timestamp::remove::also_works_locally' panicked at sudo-compliance-tests/src/sudo/timestamp/remove.rs:92:5: "[sudo: authenticate] Password:sudo-rs: interactive authentication is required" did not contain "Authentication failed" ---- sudo::timestamp::reset::it_works stdout ---- thread 'sudo::timestamp::reset::it_works' panicked at sudo-compliance-tests/src/sudo/timestamp/reset.rs:30:5: "[sudo: authenticate] Password:sudo-rs: interactive authentication is required" did not contain "incorrect authentication attempt" ---- sudo::timestamp::reset::with_command_prompts_for_password stdout ---- thread 'sudo::timestamp::reset::with_command_prompts_for_password' panicked at sudo-compliance-tests/src/sudo/timestamp/reset.rs:81:5: "[sudo: authenticate] Password:sudo-rs: interactive authentication is required" did not contain "incorrect authentication attempt" ---- sudo::timestamp::reset::with_command_does_not_cache_credentials stdout ---- thread 'sudo::timestamp::reset::with_command_does_not_cache_credentials' panicked at sudo-compliance-tests/src/sudo/timestamp/reset.rs:156:5: "sudo-rs: interactive authentication is required" did not contain "Authentication failed" ---- sudo::timestamp::validate::prompts_for_password stdout ---- thread 'sudo::timestamp::validate::prompts_for_password' panicked at sudo-compliance-tests/src/sudo/timestamp/validate.rs:46:5: "sudo-rs: interactive authentication is required" did not contain "incorrect authentication attempt" failures: sudo::flag_list::credential_caching::flag_reset_timestamp sudo::pass_auth::tty::no_tty sudo::sudoers::timestamp_timeout::nonzero sudo::sudoers::timestamp_timeout::zero_always_prompts_for_password sudo::timestamp::by_default_credential_caching_is_local sudo::timestamp::remove::also_works_locally sudo::timestamp::reset::it_works sudo::timestamp::reset::with_command_does_not_cache_credentials sudo::timestamp::reset::with_command_prompts_for_password sudo::timestamp::validate::prompts_for_password test result: FAILED. 620 passed; 10 failed; 81 ignored; 0 measured; 0 filtered out; finished in 794.44s ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to trifectatechfoundation#925
sudo -n), why not always give 'interaction is required' as error even if max tries is 0 for some odd reason?I don't necessarily like the funky
@syntax but at the same time, I can't think of a more compact way to write it at this time.