feat(suite-native): only download token definitions for relevant networks #15263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Expo preview is ready!
|
vytick
force-pushed
the
feat/native/beter-token-definitions-whitelist
branch
from
6006606
to
ee02425
Compare
yanascz
reviewed
Nov 6, 2024
| @@ -193,6 +197,15 @@ export const selectDeviceEnabledDiscoveryNetworkSymbols = memoizeWithArgs( | |||
| { size: 2 }, | |||
| ); | |||
|
|
|||
| export const selectTokenDefinitionsEnabledNetworks = memoize( | |||
There was a problem hiding this comment.
Looking at the selector name, it's not obvious what is being selected... Token definitions or enabled networks? 🤔
There was a problem hiding this comment.
I just kept the name used elsewhere
There was a problem hiding this comment.
It's confusing but if it's used elsewhere... 😏
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Part of #14399