Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token definitions fetching improvements #14399

Closed
1 task done
Nodonisko opened this issue Sep 17, 2024 · 1 comment
Closed
1 task done

Token definitions fetching improvements #14399

Nodonisko opened this issue Sep 17, 2024 · 1 comment
Labels
mobile Suite Lite issues and PRs

Comments

@Nodonisko
Copy link
Contributor

Nodonisko commented Sep 17, 2024

We should come up with better solution for fetching token definitions. We now have hardcoded eth, pol, bnb & sol which is suboptimal. Also it will fetch that definitions during startup which is also not good because parsing it is kind of slow.

possible followups:
#15252 #15253

@Nodonisko Nodonisko added the mobile Suite Lite issues and PRs label Sep 17, 2024
@vytick vytick changed the title Token definitions fetching - better solution Token definitions fetching improvements Nov 5, 2024
@vytick vytick self-assigned this Nov 5, 2024
@vytick vytick removed their assignment Nov 6, 2024
@matejkriz
Copy link
Member

Notes for QA: check that token definitions are not missing when needed (tokens have fiat rates, are visible in transaction list)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mobile Suite Lite issues and PRs
Projects
Status: 🤝 Needs QA
Development

No branches or pull requests

3 participants