Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5543] Migrate List and ListItem to TailwindCSS #4497

Merged
merged 5 commits into from
Aug 24, 2024

Conversation

ruslan-sed
Copy link
Contributor

@ruslan-sed ruslan-sed commented Aug 21, 2024

FX-5543

Description

Migrate List and ListItem to TailwindCSS.

How to test

Development checks

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@ruslan-sed ruslan-sed self-assigned this Aug 21, 2024
@ruslan-sed ruslan-sed force-pushed the fx-5543-migrate-listn-and-list-item branch from ac8744a to 12a79cd Compare August 21, 2024 11:06
Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 680199e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@toptal/picasso-list Major
@toptal/picasso Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso-forms Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ruslan-sed ruslan-sed force-pushed the fx-5543-migrate-listn-and-list-item branch 5 times, most recently from 6ac1b09 to f578ed0 Compare August 21, 2024 14:02
@ruslan-sed ruslan-sed marked this pull request as ready for review August 21, 2024 14:30
@ruslan-sed ruslan-sed requested a review from a team as a code owner August 21, 2024 14:30
@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

Copy link
Contributor

@dmaklygin dmaklygin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work. Left a couple of comments

@ruslan-sed ruslan-sed force-pushed the fx-5543-migrate-listn-and-list-item branch from f578ed0 to e1d8e33 Compare August 22, 2024 08:49
@ruslan-sed ruslan-sed force-pushed the fx-5543-migrate-listn-and-list-item branch from e1d8e33 to 1256f6d Compare August 23, 2024 08:15
@ruslan-sed ruslan-sed requested a review from sashuk August 23, 2024 08:49
@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

@sashuk sashuk mentioned this pull request Aug 23, 2024
5 tasks
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, looks exactly as before

1. Add changeset to '@toptal/picasso'
2. use Variant
3. memoize classes
4. remove bg-unset
@ruslan-sed ruslan-sed force-pushed the fx-5543-migrate-listn-and-list-item branch from 1256f6d to 424dd91 Compare August 23, 2024 12:26
@ruslan-sed
Copy link
Contributor Author

@toptal-anvil ping reviewers

@ruslan-sed ruslan-sed merged commit 1f9def0 into master Aug 24, 2024
18 checks passed
@ruslan-sed ruslan-sed deleted the fx-5543-migrate-listn-and-list-item branch August 24, 2024 12:08
@toptal-build toptal-build mentioned this pull request Aug 24, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants