-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FX-5543] Migrate List and ListItem to TailwindCSS #4497
Conversation
ac8744a
to
12a79cd
Compare
🦋 Changeset detectedLatest commit: 680199e The changes in this PR will be included in the next version bump. This PR includes changesets to release 5 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6ac1b09
to
f578ed0
Compare
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work. Left a couple of comments
f578ed0
to
e1d8e33
Compare
e1d8e33
to
1256f6d
Compare
@toptal-anvil ping reviewers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, looks exactly as before
1. Add changeset to '@toptal/picasso' 2. use Variant 3. memoize classes 4. remove bg-unset
1256f6d
to
424dd91
Compare
@toptal-anvil ping reviewers |
FX-5543
Description
Migrate List and ListItem to TailwindCSS.
How to test
Development checks
Read CONTRIBUTING.md and Component API principlesMake sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-coreAnnotate allprops
in component with documentationCreateexamples
for componentEnsure that deployed demo has expected results and good examplesEnsure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.Covered with tests (visual tests included)Breaking change
codemod is created and showcased in the changesettest alpha package of Picasso in StaffPortalPR commands
List of available commands:
@toptal-bot run package:alpha-release
- Release alpha version@toptal-anvil ping reviewers
- Ping FX team for reviewPR Review Guidelines
When to approve? ✅
You are OK with merging this PR and
nit:
to your comment. (ex.nit: I'd rename this variable from makeCircle to getCircle
)When to request changes? ❌
You are not OK with merging this PR because
When to comment (neither ✅ nor ❌)
You want your comments to be addressed before merging this PR in cases like:
How to handle the comments?