Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FX-5544] Migrate Logo to TailwindCSS #4506

Merged
merged 6 commits into from
Aug 26, 2024
Merged

[FX-5544] Migrate Logo to TailwindCSS #4506

merged 6 commits into from
Aug 26, 2024

Conversation

AdrianContiu
Copy link
Contributor

@AdrianContiu AdrianContiu commented Aug 26, 2024

FX-5544

Description

This PR removes material-ui styles and replace them with Tailwind CSS classes.

How to test

Development checks

  • Add changeset according to guidelines (if needed)
  • Double check if picasso-tailwind-merge requires major update (check its README.md)
  • Read CONTRIBUTING.md and Component API principles
  • Make sure that additions and changes on the design follow Toptal's BASE design, and it's been already discussed with designers at #-base-core
  • Annotate all props in component with documentation
  • Create examples for component
  • Ensure that deployed demo has expected results and good examples
  • Ensure the changed/created components have not caused accessibility issues. How to use accessibility plugin in storybook.
  • Self reviewed
  • Covered with tests (visual tests included)

Breaking change

  • codemod is created and showcased in the changeset
  • test alpha package of Picasso in StaffPortal

All development checks should be done and set checked to pass the
GitHub Bot: TODOLess action

PR commands

List of available commands:

  • @toptal-bot run package:alpha-release - Release alpha version
  • @toptal-anvil ping reviewers - Ping FX team for review
PR Review Guidelines

When to approve? ✅

You are OK with merging this PR and

  1. You have no extra requests.
  2. You have optional requests.
    1. Add nit: to your comment. (ex. nit: I'd rename this variable from makeCircle to getCircle)

When to request changes? ❌

You are not OK with merging this PR because

  1. Something is broken after the changes.
  2. Acceptance criteria is not reached.
  3. Code is dirty.

When to comment (neither ✅ nor ❌)

You want your comments to be addressed before merging this PR in cases like:

  1. There are leftovers like unnecessary logs, comments, etc.
  2. You have an opinionated comment regarding the code that requires a discussion.
  3. You have questions.

How to handle the comments?

  1. An owner of a comment is the only one who can resolve it.
  2. An owner of a comment must resolve it when it's addressed.
  3. A PR owner must reply with ✅ when a comment is addressed.

@AdrianContiu AdrianContiu self-assigned this Aug 26, 2024
Copy link

changeset-bot bot commented Aug 26, 2024

🦋 Changeset detected

Latest commit: 6aa1186

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@toptal/picasso-logo Major
@toptal/picasso Patch
@toptal/picasso-avatar Patch
@toptal/picasso-page Patch
@toptal/picasso-avatar-upload Patch
@toptal/picasso-menu Patch
@toptal/picasso-user-badge Patch
@toptal/picasso-forms Patch
@toptal/picasso-account-select Patch
@toptal/picasso-autocomplete Patch
@toptal/picasso-select Patch
@toptal/picasso-tabs Patch
@toptal/picasso-tagselector Patch
@toptal/picasso-query-builder Patch
@toptal/picasso-rich-text-editor Patch
@toptal/picasso-date-select Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@AdrianContiu AdrianContiu marked this pull request as ready for review August 26, 2024 09:59
@AdrianContiu AdrianContiu requested a review from a team as a code owner August 26, 2024 09:59
@TomasSlama TomasSlama requested a review from a team August 26, 2024 10:05
Copy link
Contributor

@sashuk sashuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, tested on temploy!

@AdrianContiu AdrianContiu merged commit e1b01cd into master Aug 26, 2024
18 checks passed
@AdrianContiu AdrianContiu deleted the fx-5544-logo branch August 26, 2024 13:37
@toptal-build toptal-build mentioned this pull request Aug 26, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants