-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Introduce HTTP API V2 in PD #88
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Ryan Leung <[email protected]>
@@ -0,0 +1,72 @@ | |||
# PD HTTP API V2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we introduce the store state refine? It's may influence downstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will add another section to introduce some refinement of the internal structure.
Signed-off-by: Ryan Leung <[email protected]>
|
||
### Behavior changes | ||
|
||
In V2, we are planning to refactor the original store state. The previous implementation has some drawbacks: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you like to add a store state change flow graph for v1,v2?
Signed-off-by: Ryan Leung <[email protected]>
- Removing: just like the original `Offline`, but it's more clear | ||
- Removed: the same as the original `Tombstone` | ||
|
||
As for heartbeat status, we only add one normal status named `Alive` into the previous implementation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So Disconnect
, and Down
is gone?
Signed-off-by: Ryan Leung [email protected]