Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Introduce HTTP API V2 in PD #88

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Mar 2, 2022

Signed-off-by: Ryan Leung [email protected]

@rleungx rleungx changed the title introduce HTTP API V2 in PD RFC: Introduce HTTP API V2 in PD Mar 2, 2022
@@ -0,0 +1,72 @@
# PD HTTP API V2
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we introduce the store state refine? It's may influence downstream.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I will add another section to introduce some refinement of the internal structure.

Signed-off-by: Ryan Leung <[email protected]>
@rleungx rleungx marked this pull request as ready for review March 3, 2022 03:42

### Behavior changes

In V2, we are planning to refactor the original store state. The previous implementation has some drawbacks:
Copy link
Contributor

@nolouch nolouch Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to add a store state change flow graph for v1,v2?

Signed-off-by: Ryan Leung <[email protected]>
- Removing: just like the original `Offline`, but it's more clear
- Removed: the same as the original `Tombstone`

As for heartbeat status, we only add one normal status named `Alive` into the previous implementation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So Disconnect, and Down is gone?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants