Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: aggregate the utils package within the client #8799

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Nov 11, 2024

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Aggregate the utils package within the client.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 11, 2024
@JmPotato
Copy link
Member Author

/test pull-integration-realcluster-test

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.68%. Comparing base (1265c8c) to head (bbfc968).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8799      +/-   ##
==========================================
- Coverage   75.73%   75.68%   -0.05%     
==========================================
  Files         461      461              
  Lines       72315    72315              
==========================================
- Hits        54766    54733      -33     
- Misses      14053    14076      +23     
- Partials     3496     3506      +10     
Flag Coverage Δ
unittests 75.68% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lhy1024, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 10:38:57.197507473 +0000 UTC m=+266299.388376465: ☑️ agreed by lhy1024.
  • 2024-11-12 01:55:43.795652118 +0000 UTC m=+321305.986521107: ☑️ agreed by rleungx.

@ti-chi-bot ti-chi-bot bot merged commit 2637331 into tikv:master Nov 12, 2024
26 checks passed
@JmPotato JmPotato deleted the sort_client_utils branch November 12, 2024 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants