-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client: genericize the batch controller #8793
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8793 +/- ##
==========================================
+ Coverage 75.64% 75.68% +0.03%
==========================================
Files 461 461
Lines 72300 72315 +15
==========================================
+ Hits 54690 54730 +40
+ Misses 14107 14083 -24
+ Partials 3503 3502 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
8cc9c89
to
ca09490
Compare
ca09490
to
f240187
Compare
/test pull-integration-realcluster-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: okJiang, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
Signed-off-by: JmPotato <[email protected]>
0accfcb
to
ca06db6
Compare
What problem does this PR solve?
Issue Number: ref #8690.
What is changed and how does it work?
Check List
Tests
Release note