Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: genericize the batch controller #8793

Merged
merged 4 commits into from
Nov 11, 2024

Conversation

JmPotato
Copy link
Member

@JmPotato JmPotato commented Nov 8, 2024

What problem does this PR solve?

Issue Number: ref #8690.

What is changed and how does it work?

Genericize the batch controller for the later reuse.

Check List

Tests

  • Unit test
  • Integration test

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Nov 8, 2024
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2024
Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 70.00000% with 51 lines in your changes missing coverage. Please review.

Project coverage is 75.68%. Comparing base (238d4d7) to head (ca06db6).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8793      +/-   ##
==========================================
+ Coverage   75.64%   75.68%   +0.03%     
==========================================
  Files         461      461              
  Lines       72300    72315      +15     
==========================================
+ Hits        54690    54730      +40     
+ Misses      14107    14083      -24     
+ Partials     3503     3502       -1     
Flag Coverage Δ
unittests 75.68% <70.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

client/batch_controller.go Outdated Show resolved Hide resolved
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 8, 2024
client/batch_controller.go Outdated Show resolved Hide resolved
client/batch_controller.go Outdated Show resolved Hide resolved
@JmPotato
Copy link
Member Author

/test pull-integration-realcluster-test

client/tso_dispatcher.go Outdated Show resolved Hide resolved
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Nov 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 11, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: okJiang, rleungx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Nov 11, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 06:39:44.682529245 +0000 UTC m=+251946.873398240: ☑️ agreed by rleungx.
  • 2024-11-11 07:37:25.048364356 +0000 UTC m=+255407.239233353: ☑️ agreed by okJiang.

Signed-off-by: JmPotato <[email protected]>
@ti-chi-bot ti-chi-bot bot merged commit 1265c8c into tikv:master Nov 11, 2024
23 of 25 checks passed
@JmPotato JmPotato deleted the batch_controller branch November 11, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved component/client Client logic. dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants