Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: reset config if the input is invalid (#8632) #8661

Open
wants to merge 2 commits into
base: release-6.5
Choose a base branch
from
Open

*: reset config if the input is invalid (#8632) #8661

wants to merge 2 commits into from
+95 −14

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #8632

What problem does this PR solve?

Issue Number: Close #8619.

What is changed and how does it work?

Check List

Tests

  • Unit test

Release note

None.

@ti-chi-bot ti-chi-bot added dco-signoff: yes Indicates the PR's author has signed the dco. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR. labels Sep 24, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Sep 24, 2024
Merged
@ti-chi-bot ti-chi-bot bot added do-not-merge/cherry-pick-not-approved cherry-pick-approved Cherry pick PR approved by release team. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed do-not-merge/cherry-pick-not-approved size/M Denotes a PR that changes 30-99 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Sep 24, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lhy1024
Once this PR has been reviewed and has the lgtm label, please assign kevin-xianliu for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 25, 2024
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Sep 25, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-25 05:57:56.855760773 +0000 UTC m=+1631946.596184706: ☑️ agreed by lhy1024.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Nov 8, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 8, 2024
@rleungx rleungx force-pushed the cherry-pick-8632-to-release-6.5 branch from aa219e7 to 1a4fa89 Compare November 11, 2024 07:41
@rleungx rleungx removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 11, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 11, 2024

Codecov Report

Attention: Patch coverage is 63.15789% with 7 lines in your changes missing coverage. Please review.

Project coverage is 75.56%. Comparing base (959b578) to head (1a4fa89).
Report is 1 commits behind head on release-6.5.

Files with missing lines Patch % Lines
server/schedulers/grant_leader.go 22.22% 6 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           release-6.5    #8661      +/-   ##
===============================================
- Coverage        75.64%   75.56%   -0.08%     
===============================================
  Files              332      332              
  Lines            33855    33869      +14     
===============================================
- Hits             25608    25592      -16     
- Misses            6049     6068      +19     
- Partials          2198     2209      +11
Flag Coverage Δ
unittests 75.56% <63.15%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx left review comments

@lhy1024 lhy1024 lhy1024 approved these changes

Assignees

@rleungx rleungx

Labels
cherry-pick-approved Cherry pick PR approved by release team. dco-signoff: yes Indicates the PR's author has signed the dco. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. type/cherry-pick-for-release-6.5 This PR is cherry-picked to release-6.5 from a source PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ti-chi-bot @lhy1024 @rleungx