pd-ctl: rename scatter-range to scatter-range-scheduler #8607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
release-note-none
rleungx
reviewed
Sep 9, 2024
| @@ -182,11 +181,6 @@ func SchedulerByName(name string) string { | |||
| return fmt.Sprintf("%s/%s", Schedulers, name) | |||
| } | |||
|
|
|||
| // ScatterRangeSchedulerWithName returns the scatter range scheduler API with name parameter. | |||
| func ScatterRangeSchedulerWithName(name string) string { | |||
There was a problem hiding this comment.
I have not found it in TiDB. And where is the service interface implement in PD server? 🤔
There was a problem hiding this comment.
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
size/S
Signed-off-by: okJiang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8607 +/- ##
==========================================
+ Coverage 77.62% 77.66% +0.03%
==========================================
Files 474 474
Lines 62105 62115 +10
==========================================
+ Hits 48211 48240 +29
+ Misses 10340 10332 -8
+ Partials 3554 3543 -11
Flags with carried forward coverage won't be shown. Click here to find out more. |
HuSharp
reviewed
Sep 10, 2024
Signed-off-by: okJiang <[email protected]>
ti-chi-bot
bot
added
size/M
okJiang
commented
Sep 10, 2024
| @@ -60,7 +60,7 @@ const ( | |||
| RegionLabelRulesByIDs = "/pd/api/v1/config/region-label/rules/ids" | |||
| // Scheduler | |||
| Schedulers = "/pd/api/v1/schedulers" | |||
| scatterRangeScheduler = "/pd/api/v1/schedulers/scatter-range-" | |||
| scatterRangeScheduler = "/pd/api/v1/schedulers/scatter-range-scheduler-" | |||
Signed-off-by: okJiang <[email protected]>
HuSharp
reviewed
Sep 11, 2024
Signed-off-by: okJiang <[email protected]>
HuSharp
approved these changes
Sep 11, 2024
ti-chi-bot
bot
added
needs-1-more-lgtm
rleungx
reviewed
Sep 12, 2024
| @@ -90,7 +90,7 @@ func (conf *scatterRangeSchedulerConfig) getEndKey() []byte { | |||
| func (conf *scatterRangeSchedulerConfig) getSchedulerName() string { | |||
| conf.RLock() | |||
| defer conf.RUnlock() | |||
| return fmt.Sprintf("scatter-range-%s", conf.RangeName) | |||
| return fmt.Sprintf("%s-%s", types.ScatterRangeScheduler, conf.RangeName) | |||
There was a problem hiding this comment.
need to consider the compatibility issue
There was a problem hiding this comment.
This commit fixed it. You can check it in its comment.
Signed-off-by: okJiang <[email protected]>
rleungx
approved these changes
Sep 24, 2024
ti-chi-bot
bot
added
lgtm
and removed
needs-1-more-lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, rleungx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
ti-chi-bot
bot
added
release-note
okJiang
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: Close #8379
What is changed and how does it work?
Check List
Tests
Release note