Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: make TestBatchEvict stable #8590

Merged
merged 1 commit into from
Sep 3, 2024
Merged

Conversation

rleungx
Copy link
Member

@rleungx rleungx commented Sep 3, 2024

What problem does this PR solve?

Issue Number: Close #8560

What is changed and how does it work?

We only try to schedule according to the configuration at the most specified times. However, the operator may be the same and be removed due to duplication.

Check List

Tests

  • Unit test

Release note

None.

Signed-off-by: Ryan Leung <[email protected]>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has signed the dco. labels Sep 3, 2024
@rleungx rleungx changed the title *: make TestBatchEvict stable *: make TestBatchEvict stable Sep 3, 2024
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

@rleungx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-realcluster-test 6cd48c3 link false /test pull-integration-realcluster-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ti-chi-bot ti-chi-bot bot added needs-1-more-lgtm Indicates a PR needs 1 more LGTM. approved labels Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.61%. Comparing base (571c59b) to head (6cd48c3).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8590      +/-   ##
==========================================
- Coverage   77.66%   77.61%   -0.05%     
==========================================
  Files         474      474              
  Lines       61884    61873      -11     
==========================================
- Hits        48061    48023      -38     
- Misses      10277    10317      +40     
+ Partials     3546     3533      -13     
Flag Coverage Δ
unittests 77.61% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot added the lgtm label Sep 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HuSharp, lhy1024

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Sep 3, 2024
Copy link
Contributor

ti-chi-bot bot commented Sep 3, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-03 05:44:29.155963981 +0000 UTC m=+336793.674016905: ☑️ agreed by lhy1024.
  • 2024-09-03 07:44:48.255432004 +0000 UTC m=+344012.773484929: ☑️ agreed by HuSharp.

@ti-chi-bot ti-chi-bot bot merged commit cdc86a8 into tikv:master Sep 3, 2024
24 of 26 checks passed
@rleungx rleungx deleted the fix-test-2024-21 branch September 3, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-signoff: yes Indicates the PR's author has signed the dco. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TestBatchEvict is unstable
3 participants