*: unify the usage of independent service #8508
Conversation
ti-chi-bot
bot
added
release-note-none
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8508 +/- ##
==========================================
- Coverage 77.37% 77.37% -0.01%
==========================================
Files 472 472
Lines 61828 61836 +8
==========================================
+ Hits 47839 47844 +5
- Misses 10420 10422 +2
- Partials 3569 3570 +1
Flags with carried forward coverage won't be shown. Click here to find out more. |
| return false | ||
| } | ||
| return independent.(bool) | ||
| _, exist := c.independentServices.Load(name) |
There was a problem hiding this comment.
Do we need not to check the result?
ti-chi-bot
bot
added
the
needs-rebase
Signed-off-by: Ryan Leung <[email protected]>
Signed-off-by: Ryan Leung <[email protected]>
ti-chi-bot
bot
removed
the
needs-rebase
ti-chi-bot
bot
added
needs-1-more-lgtm
| @@ -129,7 +129,7 @@ func (h *redirector) matchMicroServiceRedirectRules(r *http.Request) (bool, stri | |||
| for _, rule := range h.microserviceRedirectRules { | |||
| // Now we only support checking the scheduling service whether it is independent | |||
| if rule.targetServiceName == mcsutils.SchedulingServiceName { | |||
| if !h.s.IsServiceIndependent(mcsutils.SchedulingServiceName) { | |||
| if !h.s.GetRaftCluster().IsServiceIndependent(mcsutils.SchedulingServiceName) { | |||
There was a problem hiding this comment.
Do we need to unify mcsutils.SchedulingServiceName and utils.SchedulingServiceName as well?
There was a problem hiding this comment.
#8476 will change it to constant.xxx
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, lhy1024 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Issue Number: ref #8477.
What is changed and how does it work?
Check List
Tests
Release note