Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools/ctl: add caller ID for pd-ctl #8214

Merged
merged 2 commits into from
May 24, 2024
Merged

tools/ctl: add caller ID for pd-ctl #8214

merged 2 commits into from
May 24, 2024

Conversation

HuSharp
Copy link
Member

@HuSharp HuSharp commented May 24, 2024 •
edited
Loading

What problem does this PR solve?

Issue Number: Ref #7300

What is changed and how does it work?

After replacing HTTP with SDK #7490, we need to add the calledID explicitly to keep consistent with #4491

And source ID can be consistent with caller ID, #7565

Check List

Tests

  • Unit test

Release note

None.

@HuSharp
add caller ID
e5497d2 
Signed-off-by: husharp <[email protected]>
@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2024 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label May 24, 2024
@ti-chi-bot ti-chi-bot bot requested review from nolouch and rleungx May 24, 2024 07:28
@HuSharp HuSharp requested review from JmPotato and removed request for nolouch and rleungx May 24, 2024 07:28
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 24, 2024
@HuSharp HuSharp mentioned this pull request May 24, 2024
Merged
@HuSharp
Copy link
Member Author

HuSharp commented May 24, 2024

@okJiang PTAL, thx!

HuSharp
HuSharp commented May 24, 2024
View reviewed changes
tools/pd-ctl/tests/global_test.go
func TestSendAndGetComponent(t *testing.T) {
re := require.New(t)
handler := func(context.Context, *server.Server) (http.Handler, apiutil.APIServiceGroup, error) {
mux := http.NewServeMux()
mux.HandleFunc("/pd/api/v1/cluster", func(w http.ResponseWriter, r *http.Request) {
Copy link
Member Author

@HuSharp HuSharp May 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, only cluster command was replaced by PD HTTP SDK

@codecov Codecov
Copy link

codecov bot commented May 24, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.34%. Comparing base (4cd42b3) to head (4daa1a7).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #8214      +/-   ##
==========================================
+ Coverage   77.29%   77.34%   +0.05%     
==========================================
  Files         471      471              
  Lines       61445    61445              
==========================================
+ Hits        47491    47527      +36     
+ Misses      10395    10350      -45     
- Partials     3559     3568       +9
Flag Coverage Δ
unittests 77.34% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

okJiang
okJiang approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@okJiang okJiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment to explain why we need two handle for testing. Rest lgtm

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2024

@okJiang: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Please add a comment to explain why we need two handle for testing. Rest lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HuSharp
add comment for test
4daa1a7 
Signed-off-by: husharp <[email protected]>
@HuSharp HuSharp requested a review from JmPotato May 24, 2024 08:02
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label May 24, 2024
@HuSharp HuSharp added the require-LGT1 Indicates that the PR requires an LGTM. label May 24, 2024
@HuSharp
Copy link
Member Author

HuSharp commented May 24, 2024

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2024

@HuSharp: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2024

This pull request has been accepted and is ready to merge.

Commit hash: 4daa1a7

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label May 24, 2024
@JmPotato
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented May 24, 2024

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@HuSharp HuSharp removed the require-LGT1 Indicates that the PR requires an LGTM. label May 24, 2024
@ti-chi-bot ti-chi-bot bot merged commit 7cc3b4e into tikv:master May 24, 2024
19 checks passed
@HuSharp HuSharp deleted the fix_ctl_calledID branch May 24, 2024 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rleungx rleungx rleungx approved these changes

@okJiang okJiang okJiang approved these changes

@JmPotato JmPotato JmPotato approved these changes

Assignees
No one assigned
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HuSharp @JmPotato @okJiang @rleungx