-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
client/http: pass res interface into respHandler #7404
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: JmPotato <[email protected]>
f181920
to
8d10a15
Compare
/merge |
@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: 8d10a15
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7404 +/- ##
==========================================
+ Coverage 74.23% 74.28% +0.05%
==========================================
Files 451 451
Lines 49169 49170 +1
==========================================
+ Hits 36499 36525 +26
+ Misses 9433 9416 -17
+ Partials 3237 3229 -8
Flags with carried forward coverage won't be shown. Click here to find out more. |
What problem does this PR solve?
Issue Number: ref #7300.
What is changed and how does it work?
Check List
Tests
Release note