Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client/http: pass res interface into respHandler #7404

Merged
merged 1 commit into from
Nov 21, 2023

Conversation

JmPotato
Copy link
Member

What problem does this PR solve?

Issue Number: ref #7300.

What is changed and how does it work?

Pass `res` interface into `respHandler`.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)

Release note

None.

@JmPotato JmPotato added the component/client Client logic. label Nov 21, 2023
Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • rleungx

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Nov 21, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 21, 2023
@JmPotato JmPotato mentioned this pull request Nov 21, 2023
7 tasks
@JmPotato JmPotato added the require-LGT1 Indicates that the PR requires an LGTM. label Nov 21, 2023
@JmPotato
Copy link
Member Author

/merge

Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023

@JmPotato: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Copy link
Contributor

ti-chi-bot bot commented Nov 21, 2023

This pull request has been accepted and is ready to merge.

Commit hash: 8d10a15

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #7404 (8d10a15) into master (2349f01) will increase coverage by 0.05%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7404      +/-   ##
==========================================
+ Coverage   74.23%   74.28%   +0.05%     
==========================================
  Files         451      451              
  Lines       49169    49170       +1     
==========================================
+ Hits        36499    36525      +26     
+ Misses       9433     9416      -17     
+ Partials     3237     3229       -8     
Flag Coverage Δ
unittests 74.28% <0.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@ti-chi-bot ti-chi-bot bot merged commit 8919bc1 into tikv:master Nov 21, 2023
23 of 26 checks passed
@JmPotato JmPotato deleted the fix_http_client_request branch November 21, 2023 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/client Client logic. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants