-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
global config: fix etcd client not found (#6866) #6935
global config: fix etcd client not found (#6866) #6935
Conversation
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
Signed-off-by: husharp <[email protected]>
ac4b4d9
to
ea212a7
Compare
@@ -1835,6 +1836,9 @@ const globalConfigPath = "/global/config/" | |||
// Since item value needs to support marshal of different struct types, | |||
// it should be set to `Payload bytes` instead of `Value string` | |||
func (s *GrpcServer) StoreGlobalConfig(_ context.Context, request *pdpb.StoreGlobalConfigRequest) (*pdpb.StoreGlobalConfigResponse, error) { | |||
if s.client == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to pick it to other branches?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, due to this pr, seems like we need to change a lot...
https://github.com/tikv/pd/pull/4308/files#diff-eb404b45d0a569b05f58f4e4bf2b42b32150be75ec2ed72f86330c4b5d739eab
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## release-7.1 #6935 +/- ##
===============================================
+ Coverage 74.96% 74.98% +0.02%
===============================================
Files 406 406
Lines 40755 40820 +65
===============================================
+ Hits 30551 30608 +57
- Misses 7539 7541 +2
- Partials 2665 2671 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/merge |
@nolouch: It seems you want to merge this PR, I will help you trigger all the tests: /run-all-tests You only need to trigger
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
This pull request has been accepted and is ready to merge. Commit hash: ea212a7
|
This is an automated cherry-pick of #6866
What problem does this PR solve?
Issue Number: Close #6860,#6858
What is changed and how does it work?
Check List
Tests
Release note