Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dynamic Regions] Enable evict-slow-trend on multi-rocksdb mode. #6885

Conversation

LykxSassinator
Copy link
Contributor

@LykxSassinator LykxSassinator commented Aug 2, 2023

What problem does this PR solve?

Issue Number: close #6868, ref tikv/tikv#15271.

What is changed and how does it work?

Enable `evict-slow-trend` on `multi-rocksdb` mode as default.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

Release note

None.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. labels Aug 2, 2023
@ti-chi-bot ti-chi-bot bot added the needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. label Aug 2, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 2, 2023

Hi @LykxSassinator. Thanks for your PR.

I'm waiting for a tikv member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot requested review from lhy1024 and rleungx August 2, 2023 11:39
@ti-chi-bot ti-chi-bot bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #6885 (4ec5f23) into master (7dc9d17) will decrease coverage by 0.18%.
The diff coverage is 60.00%.

❗ Current head 4ec5f23 differs from pull request most recent head 78a6eeb. Consider uploading reports for the commit 78a6eeb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6885      +/-   ##
==========================================
- Coverage   74.51%   74.33%   -0.18%     
==========================================
  Files         427      427              
  Lines       45149    45168      +19     
==========================================
- Hits        33642    33576      -66     
- Misses       8552     8637      +85     
  Partials     2955     2955              
Flag Coverage Δ
unittests 74.33% <60.00%> (-0.18%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@LykxSassinator
Copy link
Contributor Author

Records when building a cluster with raft-kv-2 engine(multi-rocksdb):

[2023/08/04 07:33:40.560 +00:00] [INFO] [store_config.go:231] ["sync the store config successful"] [store-address=10.233.108.15:20180] [store-config="{\n  \"coprocessor\": {\n    \"region-max-size\": \"15GiB\",\n    \"region-split-size\": \"10GiB\",\n    \"region-max-keys
\": 153600000,\n    \"region-split-keys\": 102400000,\n    \"enable-region-bucket\": true,\n    \"region-bucket-size\": \"50MiB\"\n  },\n  \"storage\": {\n    \"engine\": \"raft-kv2\"\n  }\n}"] [old-config="{\n  \"coprocessor\": {\n    \"region-max-size\": \"\",\n    \"re
gion-split-size\": \"\",\n    \"region-max-keys\": 0,\n    \"region-split-keys\": 0,\n    \"enable-region-bucket\": false,\n    \"region-bucket-size\": \"\"\n  },\n  \"storage\": {\n    \"engine\": \"\"\n  }\n}"]
[2023/08/04 07:33:40.561 +00:00] [INFO] [cluster.go:440] ["create scheduler"] [scheduler-name=evict-slow-trend-scheduler] [scheduler-args="[]"]
[2023/08/04 07:33:40.561 +00:00] [INFO] [cluster.go:446] ["add scheduler successfully"] [scheduler-name=evict-slow-trend] [scheduler-args="[]"]

And we got the following metrics:
image

@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 7, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 8, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 8, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 9, 2023
@LykxSassinator
Copy link
Contributor Author

Closed as #6945 is a formal one for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR created by contributors and need ORG member send '/ok-to-test' to start testing. release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dynamic Regions] enable slow-trend-scheduler by default
2 participants