Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replication mode: tune persist file timeout #6669

Merged
merged 1 commit into from
Jun 26, 2023

Conversation

disksing
Copy link
Contributor

@disksing disksing commented Jun 25, 2023

Issue Number: Fix #6672

What is changed and how does it work?

change persist file timeout from 10s to 3s to speed up state change

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

Release note

None.

@disksing disksing added the status/DNM Do not merge this PR. label Jun 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 25, 2023

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • nolouch

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 25, 2023
@ti-chi-bot ti-chi-bot bot requested review from HunDunDM and JmPotato June 25, 2023 08:20
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 25, 2023
@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.56%. Comparing base (ec99986) to head (d4479a9).
Report is 875 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6669      +/-   ##
==========================================
- Coverage   74.65%   74.56%   -0.09%     
==========================================
  Files         417      417              
  Lines       43278    43278              
==========================================
- Hits        32309    32271      -38     
- Misses       8100     8134      +34     
- Partials     2869     2873       +4     
Flag Coverage Δ
unittests 74.56% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@disksing disksing requested a review from nolouch June 25, 2023 10:57
@disksing disksing removed the status/DNM Do not merge this PR. label Jun 25, 2023
@ti-chi-bot ti-chi-bot bot added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 25, 2023
@disksing disksing added the require-LGT1 Indicates that the PR requires an LGTM. label Jun 26, 2023
@disksing
Copy link
Contributor Author

/merge

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2023

@disksing: It seems you want to merge this PR, I will help you trigger all the tests:

/run-all-tests

You only need to trigger /merge once, and if the CI test fails, you just re-trigger the test that failed and the bot will merge the PR for you after the CI passes.

If you have any questions about the PR merge process, please refer to pr process.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 26, 2023

This pull request has been accepted and is ready to merge.

Commit hash: d4479a9

@ti-chi-bot ti-chi-bot bot added the status/can-merge Indicates a PR has been approved by a committer. label Jun 26, 2023
@ti-chi-bot ti-chi-bot bot merged commit eed021d into tikv:master Jun 26, 2023
@disksing disksing deleted the disksing/timeout branch June 26, 2023 01:34
@ti-chi-bot ti-chi-bot bot added the needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. label Nov 6, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-7.1: #8774.

ti-chi-bot pushed a commit to ti-chi-bot/pd that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. release-note-none Denotes a PR that doesn't merit a release note. require-LGT1 Indicates that the PR requires an LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[dr-autosync] block read/write more than 40s during change sync to async
3 participants