-
Notifications
You must be signed in to change notification settings - Fork 721
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
scheduler: skip evict-leader-scheduler when setting schedule deny lab…
…el (#8303) ref #7300, close #7853 - add a real cluster test to test `skip evict-leader-scheduler when setting schedule deny label` - add `DeleteStoreLabel` API and `DeleteScheduler` API Signed-off-by: okJiang <[email protected]>
- Loading branch information
Showing
14 changed files
with
261 additions
and
80 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -26,3 +26,4 @@ coverage | |
| *.txt | ||
| go.work* | ||
| embedded_assets_handler.go | ||
| *.log | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| [schedule] | ||
| patrol-region-interval = "100ms" | ||
|
|
||
| [log] | ||
| level = "debug" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,188 @@ | ||
| // Copyright 2024 TiKV Authors | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package realcluster | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "sort" | ||
| "testing" | ||
| "time" | ||
|
|
||
| "github.com/stretchr/testify/require" | ||
| pd "github.com/tikv/pd/client/http" | ||
| "github.com/tikv/pd/client/testutil" | ||
| "github.com/tikv/pd/pkg/schedule/labeler" | ||
| "github.com/tikv/pd/pkg/schedule/schedulers" | ||
| ) | ||
|
|
||
| // https://github.com/tikv/pd/issues/6988#issuecomment-1694924611 | ||
| // https://github.com/tikv/pd/issues/6897 | ||
| func TestTransferLeader(t *testing.T) { | ||
| re := require.New(t) | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
|
|
||
| resp, err := pdHTTPCli.GetLeader(ctx) | ||
| re.NoError(err) | ||
| oldLeader := resp.Name | ||
|
|
||
| var newLeader string | ||
| for i := 0; i < 2; i++ { | ||
| if resp.Name != fmt.Sprintf("pd-%d", i) { | ||
| newLeader = fmt.Sprintf("pd-%d", i) | ||
| } | ||
| } | ||
|
|
||
| // record scheduler | ||
| re.NoError(pdHTTPCli.CreateScheduler(ctx, schedulers.EvictLeaderName, 1)) | ||
| defer func() { | ||
| re.NoError(pdHTTPCli.DeleteScheduler(ctx, schedulers.EvictLeaderName)) | ||
| }() | ||
| res, err := pdHTTPCli.GetSchedulers(ctx) | ||
| re.NoError(err) | ||
| oldSchedulersLen := len(res) | ||
|
|
||
| re.NoError(pdHTTPCli.TransferLeader(ctx, newLeader)) | ||
| // wait for transfer leader to new leader | ||
| time.Sleep(1 * time.Second) | ||
| resp, err = pdHTTPCli.GetLeader(ctx) | ||
| re.NoError(err) | ||
| re.Equal(newLeader, resp.Name) | ||
|
|
||
| res, err = pdHTTPCli.GetSchedulers(ctx) | ||
| re.NoError(err) | ||
| re.Len(res, oldSchedulersLen) | ||
|
|
||
| // transfer leader to old leader | ||
| re.NoError(pdHTTPCli.TransferLeader(ctx, oldLeader)) | ||
| // wait for transfer leader | ||
| time.Sleep(1 * time.Second) | ||
| resp, err = pdHTTPCli.GetLeader(ctx) | ||
| re.NoError(err) | ||
| re.Equal(oldLeader, resp.Name) | ||
|
|
||
| res, err = pdHTTPCli.GetSchedulers(ctx) | ||
| re.NoError(err) | ||
| re.Len(res, oldSchedulersLen) | ||
| } | ||
|
|
||
| func TestRegionLabelDenyScheduler(t *testing.T) { | ||
| re := require.New(t) | ||
| ctx, cancel := context.WithCancel(context.Background()) | ||
| defer cancel() | ||
|
|
||
| regions, err := pdHTTPCli.GetRegions(ctx) | ||
| re.NoError(err) | ||
| re.GreaterOrEqual(len(regions.Regions), 1) | ||
| region1 := regions.Regions[0] | ||
|
|
||
| err = pdHTTPCli.DeleteScheduler(ctx, schedulers.BalanceLeaderName) | ||
| if err == nil { | ||
| defer func() { | ||
| pdHTTPCli.CreateScheduler(ctx, schedulers.BalanceLeaderName, 0) | ||
| }() | ||
| } | ||
|
|
||
| re.NoError(pdHTTPCli.CreateScheduler(ctx, schedulers.GrantLeaderName, uint64(region1.Leader.StoreID))) | ||
| defer func() { | ||
| pdHTTPCli.DeleteScheduler(ctx, schedulers.GrantLeaderName) | ||
| }() | ||
|
|
||
| // wait leader transfer | ||
| testutil.Eventually(re, func() bool { | ||
| regions, err := pdHTTPCli.GetRegions(ctx) | ||
| re.NoError(err) | ||
| for _, region := range regions.Regions { | ||
| if region.Leader.StoreID != region1.Leader.StoreID { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| }, testutil.WithWaitFor(time.Minute)) | ||
|
|
||
| // disable schedule for region1 | ||
| labelRule := &pd.LabelRule{ | ||
| ID: "rule1", | ||
| Labels: []pd.RegionLabel{{Key: "schedule", Value: "deny"}}, | ||
| RuleType: "key-range", | ||
| Data: labeler.MakeKeyRanges(region1.StartKey, region1.EndKey), | ||
| } | ||
| re.NoError(pdHTTPCli.SetRegionLabelRule(ctx, labelRule)) | ||
| defer func() { | ||
| pdHTTPCli.PatchRegionLabelRules(ctx, &pd.LabelRulePatch{DeleteRules: []string{labelRule.ID}}) | ||
| }() | ||
| labelRules, err := pdHTTPCli.GetAllRegionLabelRules(ctx) | ||
| re.NoError(err) | ||
| re.Len(labelRules, 2) | ||
| sort.Slice(labelRules, func(i, j int) bool { | ||
| return labelRules[i].ID < labelRules[j].ID | ||
| }) | ||
| re.Equal(labelRule.ID, labelRules[1].ID) | ||
| re.Equal(labelRule.Labels, labelRules[1].Labels) | ||
| re.Equal(labelRule.RuleType, labelRules[1].RuleType) | ||
|
|
||
| // enable evict leader scheduler, and check it works | ||
| re.NoError(pdHTTPCli.DeleteScheduler(ctx, schedulers.GrantLeaderName)) | ||
| re.NoError(pdHTTPCli.CreateScheduler(ctx, schedulers.EvictLeaderName, uint64(region1.Leader.StoreID))) | ||
| defer func() { | ||
| pdHTTPCli.DeleteScheduler(ctx, schedulers.EvictLeaderName) | ||
| }() | ||
| testutil.Eventually(re, func() bool { | ||
| regions, err := pdHTTPCli.GetRegions(ctx) | ||
| re.NoError(err) | ||
| for _, region := range regions.Regions { | ||
| if region.Leader.StoreID == region1.Leader.StoreID { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| }, testutil.WithWaitFor(time.Minute)) | ||
|
|
||
| re.NoError(pdHTTPCli.DeleteScheduler(ctx, schedulers.EvictLeaderName)) | ||
| re.NoError(pdHTTPCli.CreateScheduler(ctx, schedulers.GrantLeaderName, uint64(region1.Leader.StoreID))) | ||
| defer func() { | ||
| pdHTTPCli.DeleteScheduler(ctx, schedulers.GrantLeaderName) | ||
| }() | ||
| testutil.Eventually(re, func() bool { | ||
| regions, err := pdHTTPCli.GetRegions(ctx) | ||
| re.NoError(err) | ||
| for _, region := range regions.Regions { | ||
| if region.ID == region1.ID { | ||
| continue | ||
| } | ||
| if region.Leader.StoreID != region1.Leader.StoreID { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| }, testutil.WithWaitFor(time.Minute)) | ||
|
|
||
| pdHTTPCli.PatchRegionLabelRules(ctx, &pd.LabelRulePatch{DeleteRules: []string{labelRule.ID}}) | ||
| labelRules, err = pdHTTPCli.GetAllRegionLabelRules(ctx) | ||
| re.NoError(err) | ||
| re.Len(labelRules, 1) | ||
|
|
||
| testutil.Eventually(re, func() bool { | ||
| regions, err := pdHTTPCli.GetRegions(ctx) | ||
| re.NoError(err) | ||
| for _, region := range regions.Regions { | ||
| if region.Leader.StoreID != region1.Leader.StoreID { | ||
| return false | ||
| } | ||
| } | ||
| return true | ||
| }, testutil.WithWaitFor(time.Minute)) | ||
| } |
Oops, something went wrong.