-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add candlepin repositories for Katello staging #1743
Merged
Odilhao
merged 2 commits into
theforeman:master
from
ekohl:add-candlepin-repositories-variable
Dec 7, 2023
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
--- | ||
candlepin_repositories_version: '4.3' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
--- | ||
- name: "Add Candlepin {{ candlepin_repositories_version }} repository" | ||
yum_repository: | ||
name: candlepin-repository | ||
description: Candlepin {{ candlepin_repositories_version }} | ||
baseurl: "https://yum.theforeman.org/candlepin/{{ candlepin_repositories_version }}/el{{ ansible_distribution_major_version }}/$basearch/" | ||
gpgcheck: no | ||
enabled: yes | ||
|
||
- name: 'Enable pki-core module' | ||
command: dnf module enable -y pki-core | ||
# can't use the `dnf` module for modules without a default stream | ||
# https://github.com/ansible/ansible/issues/56504 | ||
# https://github.com/ansible/ansible/issues/64852 | ||
args: | ||
creates: /etc/dnf/modules.d/pki-core.module | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -86,17 +86,15 @@ def main(): | |
'foreman_puppet_repositories_version': version['puppet'], | ||
'pulpcore_repositories_version': version['pulpcore'], | ||
} | ||
if 'candlepin' in version: | ||
forklift_vars['candlepin_repositories_version'] = version['candlepin'] | ||
ret = forklift_vars | ||
break | ||
else: | ||
possible_versions = set() | ||
for version in reversed(versions['installers']): | ||
if not scenario_os in version['boxes']: | ||
continue | ||
# this is a hack, to be removed once all Katello versions support EL8 in the same manner Foreman does | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 😆 |
||
# aka: when 4.4 is released | ||
if scenario == 'katello' and (scenario_os.startswith('centos8') or scenario_os.startswith('almalinux8')) and version_sort_key(version[scenario]) < version_sort_key('4.0'): | ||
continue | ||
if version_sort_key(version[scenario]) <= version_sort_key(scenario_version): | ||
possible_versions.add(version[scenario]) | ||
possible_versions = list(sorted(possible_versions, key=version_sort_key, reverse=True)) | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
technically this is not required as people will enabled
katello:el8
which pulls that in?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now I will leave it there so you can use candlepin standalone.