Add candlepin repositories for Katello staging #1743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we also need to change the katello_repositories_version here to candlepin_repositories_version
|
ekohl
force-pushed
the
add-candlepin-repositories-variable
branch
3 times, most recently
from
22049c1
to
d8b3665
Compare
evgeni
requested changes
Dec 7, 2023
Comment on lines
+10
to
+16
| - name: 'Enable pki-core module' | ||
| command: dnf module enable -y pki-core | ||
| # can't use the `dnf` module for modules without a default stream | ||
| # https://github.com/ansible/ansible/issues/56504 | ||
| # https://github.com/ansible/ansible/issues/64852 | ||
| args: | ||
| creates: /etc/dnf/modules.d/pki-core.module |
There was a problem hiding this comment.
technically this is not required as people will enabled katello:el8 which pulls that in?
There was a problem hiding this comment.
For now I will leave it there so you can use candlepin standalone.
| ret = forklift_vars | ||
| break | ||
| else: | ||
| possible_versions = set() | ||
| for version in reversed(versions['installers']): | ||
| if not scenario_os in version['boxes']: | ||
| continue | ||
| # this is a hack, to be removed once all Katello versions support EL8 in the same manner Foreman does |
Candlepin now has its own release cycle and we'l always use the real repositories. The version is now tracked in versions.yaml, just like Pulpcore.
ekohl
force-pushed
the
add-candlepin-repositories-variable
branch
from
d8b3665
to
ae685c5
Compare
Odilhao
approved these changes
Dec 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.