-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "OS" to "operating system" per RHSSG #3440
Conversation
da89a9a
to
594198e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Try rebasing to see whether that fixes the failed Vale check. |
@apinnick The Vale error seems unrelated to changes in this PR. I've tried rerunning the Vale check, but it ends up with the same error. Care to investigate? Could there be a problem on the stable branch? Either way, I haven't seen it before. |
@rh-max Unfortunately, there are conflicts again on 3.11. Since it's just a style fix, it is not necessary to propagate it to older releases if everyone agrees. |
@Lennonka See my comment. We fixed the error in the main repo. PRs need to be rebased to pick up the fix. |
What changes are you introducing?
Cherrypicking #3387 into 3.12.
If successful, please also cherrypick down to 3.5, thank you.