Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "OS" to "operating system" per RHSSG #3440

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented Nov 8, 2024

What changes are you introducing?

Cherrypicking #3387 into 3.12.

If successful, please also cherrypick down to 3.5, thank you.

Copy link

github-actions bot commented Nov 8, 2024

@rh-max rh-max force-pushed the 3.12-fix-style-os-abbrev-cp branch from da89a9a to 594198e Compare November 8, 2024 09:03
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@rh-max rh-max added Needs style review Requires a review from docs style/grammar perspective Needs re-review and removed Needs style review Requires a review from docs style/grammar perspective labels Nov 8, 2024
@apinnick
Copy link
Contributor

Try rebasing to see whether that fixes the failed Vale check.

@Lennonka
Copy link
Contributor

Lennonka commented Nov 14, 2024

@apinnick The Vale error seems unrelated to changes in this PR. I've tried rerunning the Vale check, but it ends up with the same error. Care to investigate? Could there be a problem on the stable branch? Either way, I haven't seen it before.

@Lennonka Lennonka merged commit c03373d into theforeman:3.12 Nov 14, 2024
8 of 9 checks passed
@Lennonka
Copy link
Contributor

@rh-max Unfortunately, there are conflicts again on 3.11. Since it's just a style fix, it is not necessary to propagate it to older releases if everyone agrees.

@apinnick
Copy link
Contributor

@apinnick The Vale error seems unrelated to changes in this PR. I've tried rerunning the Vale check, but it ends up with the same error. Care to investigate? Could there be a problem on the stable branch? Either way, I haven't seen it before.

@Lennonka See my comment. We fixed the error in the main repo. PRs need to be rebased to pick up the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants