-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change "OS" to "operating system" per RHSSG #3387
Conversation
/label need-tech-review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Maxim, welcome again to Foreman docs. Diff LGTM minus two file names. In foreman-documentation, we always ensure that the anchor, title, and file name match (minus "proc_" etc prefixes)
guides/common/modules/proc_determining-hardware-and-os-configuration.adoc
Show resolved
Hide resolved
...dules/proc_restricting-customrepoid-to-a-specific-os-version-or-architecture-in-project.adoc
Show resolved
Hide resolved
49b32a4
to
34550cf
Compare
7b19335
to
fd91a2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This is a style modification, therefore, no tech review should be needed and I'm setting the |
@rh-max Unfortunately, I cannot even cherry pick this to 3.12. There are conflicts. Please, file a new PR on the stable branch if you think it's important to get it to older branches as well. |
What changes are you introducing?
Substituting all occurences of "OS" for "operating system".
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
https://issues.redhat.com/browse/SAT-23961
Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
--
Checklists
Please cherry-pick my commits into: