Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change "OS" to "operating system" per RHSSG #3387

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

rh-max
Copy link
Contributor

@rh-max rh-max commented Oct 22, 2024

What changes are you introducing?

Substituting all occurences of "OS" for "operating system".

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

https://issues.redhat.com/browse/SAT-23961

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

--

Checklists

  • I am okay with my commits getting squashed when you merge this PR.
  • I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

  • Foreman 3.12/Katello 4.14 (Satellite 6.16)
  • Foreman 3.11/Katello 4.13
  • Foreman 3.10/Katello 4.12
  • Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
  • Foreman 3.8/Katello 4.10
  • Foreman 3.7/Katello 4.9 (Satellite 6.14)
  • Foreman 3.6/Katello 4.8
  • Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
  • We do not accept PRs for Foreman older than 3.5.

Copy link

github-actions bot commented Oct 22, 2024

The PR preview for 34f0dd0 is available at theforeman-foreman-documentation-preview-pr-3387.surge.sh

The following output files are affected by this PR:

show diff

show diff as HTML

@rh-max
Copy link
Contributor Author

rh-max commented Oct 22, 2024

/label need-tech-review
/label need-style-review

Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Maxim, welcome again to Foreman docs. Diff LGTM minus two file names. In foreman-documentation, we always ensure that the anchor, title, and file name match (minus "proc_" etc prefixes)

@pr-processor pr-processor bot added Waiting on contributor Requires an action from the author and removed Not yet reviewed labels Oct 23, 2024
@pr-processor pr-processor bot added Needs re-review and removed Waiting on contributor Requires an action from the author labels Nov 4, 2024
@rh-max rh-max force-pushed the fix-style-os-abbrev branch 2 times, most recently from 7b19335 to fd91a2a Compare November 4, 2024 09:40
Copy link
Contributor

@maximiliankolb maximiliankolb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maximiliankolb maximiliankolb added the style review done No issues from docs style/grammar perspective label Nov 4, 2024
@Lennonka
Copy link
Contributor

Lennonka commented Nov 5, 2024

This is a style modification, therefore, no tech review should be needed and I'm setting the tech review done label.

@Lennonka Lennonka added the tech review done No issues from the technical perspective label Nov 5, 2024
@Lennonka Lennonka merged commit eec780f into theforeman:master Nov 5, 2024
8 of 9 checks passed
@Lennonka
Copy link
Contributor

Lennonka commented Nov 5, 2024

@rh-max Unfortunately, I cannot even cherry pick this to 3.12. There are conflicts. Please, file a new PR on the stable branch if you think it's important to get it to older branches as well.

@rh-max
Copy link
Contributor Author

rh-max commented Nov 8, 2024

@rh-max Unfortunately, I cannot even cherry pick this to 3.12. There are conflicts. Please, file a new PR on the stable branch if you think it's important to get it to older branches as well.

Thanks, created the cherrypick PR: #3440

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
style review done No issues from docs style/grammar perspective tech review done No issues from the technical perspective
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants