Properly send in params in the Python API example #3406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Python's requests library accepts a dict with params and then properly encodes this to be sent to a server. This avoids the need to manually encode this in our examples. This also fixes a build issue in Red Hat's downstream where Pantheon fails on &.
|
The PR preview for 62ab31f is available at theforeman-foreman-documentation-preview-pr-3406.surge.sh The following output files are affected by this PR: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you introducing?
Python's requests library accepts a dict with params and then properly encodes this to be sent to a server. This avoids the need to manually encode this in our examples.
Why are you introducing these changes? (Explanation, links to references, issues, etc.)
This fixes a build issue in Red Hat's downstream where Pantheon fails on
&, but generally is safer and more understandable code.Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)
This is an alternative to #3405.
I must admit I haven't tried this on a real system and is solely written based on knowing Python and requests.
Checklists
Please cherry-pick my commits into: