Replacing '&' with '&'

[apinnick]

What changes are you introducing?

Replacing & with &

Why are you introducing these changes? (Explanation, links to references, issues, etc.)

Trying to fix broken XML build in Pantheon

Anything else to add? (Considerations, potential downsides, alternative solutions you have explored, etc.)

Checklists

• I am okay with my commits getting squashed when you merge this PR.
• [ x] I am familiar with the contributing guidelines.

Please cherry-pick my commits into:

• Foreman 3.12/Katello 4.14 (Satellite 6.16)
• Foreman 3.11/Katello 4.13
• Foreman 3.10/Katello 4.12
• Foreman 3.9/Katello 4.11 (Satellite 6.15; orcharhino 6.8/6.9/6.10)
• Foreman 3.8/Katello 4.10
• Foreman 3.7/Katello 4.9 (Satellite 6.14)
• Foreman 3.6/Katello 4.8
• Foreman 3.5/Katello 4.7 (Satellite 6.13; orcharhino 6.6/6.7)
• We do not accept PRs for Foreman older than 3.5.

[github-actions]

The PR preview for 4c4f724 is available at theforeman-foreman-documentation-preview-pr-3405.surge.sh

The following output files are affected by this PR:

• Project_API/index-foreman-deb.html
• Project_API/index-foreman-el.html
• Project_API/index-katello.html
• Project_API/index-orcharhino.html
• Project_API/index-satellite.html

show diff

show diff as HTML

[Lennonka]

LGTM

[ekohl]

I think this breaks the guide in upstream, so a difference in how Pantheon handles it vs plain asciidoc. Any thoughts on rewriting the code avoid needing this in the first place? I'm trying to find the branch where I already did that, but I can't find it now.

[apinnick]

I think this breaks the guide in upstream, so a difference in how Pantheon handles it vs plain asciidoc. Any thoughts on rewriting the code avoid needing this in the first place? I'm trying to find the branch where I already did that, but I can't find it now.

@ekohl I am not sure what you mean by "breaks the guide in upstream". The upstream guides all render the code correctly.

display_info_for_hosts(FOREMAN_API + 'hosts?per_page=1&search=name~' + host_pattern)

[apinnick]

If @ekohl 's PR is merged, we can close this PR.

[ekohl]

I think you're right and I only looked at the diff, but forgot the HTML escaping is then still interpreted by the browser. Consider my objections gone. I don't mind merging this and then we can give my PR a proper review with the urgency behind it.

[apinnick]

Merged to 'master' and cherry-picked:
7e4d6f7..6c84233 3.12 -> 3.12