[Syntax] Use no-op PlatformMutex implemtation for wasm32-unknown-wasi #2944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can be detected with `defined(__wasi__) && !defined(_REENTRANT)`
ahoppen
approved these changes
Jan 20, 2025
This was referenced Jan 20, 2025
kkebo
approved these changes
Jan 20, 2025
There was a problem hiding this comment.
All tests have passed on kkebo/swift-syntax and kkebo/swift-format CI, and I confirmed that swift-format.wasm worked well on Wasm runtimes (wasmtime and a-Shell).
LGTM. Thank you very much for your help.
wasm32-unknown-wasi
- [DNM] test swiftlang/swift-syntax#2944 kkebo/swift-syntax#148
- [DNM] test swiftlang/swift-syntax#2944 kkebo/swift-format#221
- test results: https://github.com/kkebo/swift-format/actions/runs/12865396095/job/35865829092?pr=221
- swift-format.wasm binary: https://github.com/kkebo/swift-format/actions/runs/12867448466
wasm32-unknown-wasip1-threads
|
@swift-ci Please test |
|
@swift-ci Please test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can be detected with
defined(__wasi__) && !defined(_REENTRANT)Fixes kkebo#145