Can't build

[kkebo]

Description

swiftlang#2925 broke WASI build.

The latest implementation is swiftlang#2934.

Steps to Reproduce

https://github.com/kkebo/swift-syntax/actions/runs/12723180378/job/35468017064

[rintaro]

error: link command failed with exit code 1 (use -v to see invocation)
wasm-ld: error: /__w/swift-syntax/swift-syntax/.build/wasm32-unknown-wasi/release/_SwiftSyntaxCShims.build/PlatformMutex.c.o: undefined symbol: pthread_mutex_init
wasm-ld: error: /__w/swift-syntax/swift-syntax/.build/wasm32-unknown-wasi/release/_SwiftSyntaxCShims.build/PlatformMutex.c.o: undefined symbol: pthread_mutex_lock
wasm-ld: error: /__w/swift-syntax/swift-syntax/.build/wasm32-unknown-wasi/release/_SwiftSyntaxCShims.build/PlatformMutex.c.o: undefined symbol: pthread_mutex_unlock
wasm-ld: error: /__w/swift-syntax/swift-syntax/.build/wasm32-unknown-wasi/release/_SwiftSyntaxCShims.build/PlatformMutex.c.o: undefined symbol: pthread_mutex_destroy

Does this mean pthread.h does exist, but it actually don't have the library? That doesn't sound ideal.
But anyway, pthread is only used here https://github.com/swiftlang/swift-syntax/blob/main/Sources/_SwiftSyntaxCShims/PlatformMutex.c

If the target is not a multi-thread environment, feel free to add something like

#elif <CONDITION>
PlatformMutex swiftsyntax_platform_mutex_create() {
  PlatformMutex m;
  m.opaque = 0;
  return m;
}
void swiftsyntax_platform_mutex_lock(PlatformMutex m) {}
void swiftsyntax_platform_mutex_unlock(PlatformMutex m) {}
void swiftsyntax_platform_mutex_destroy(PlatformMutex m) {}

(before #elif __has_include(<pthread.h>))

Since I personally don't know the preprocessor macro for WASI, contribution is appreciated.

[rintaro]

Oooh, I thought here is swiftlang/swift-syntax sorry for the noise 😅

[kkebo]

@rintaro Thank you for your comment and suggestion.

Yes, wasm32-unknown-wasi is not a multi-thread environment. However, wasm32-unknown-wasip1-threads is.

The description of the following PR is helpful.

swiftlang/swift-cmark#75

I'll try to contribute, but I may be busy for a month or so and may not get around to it.

[kkebo]

I could have created an issue in swiftlang/swift-syntax, but I wasn't sure if they had officially supported WASI or not, so I created an issue here for now.

[rintaro]

Sounds good. Here is the PR swiftlang#2944
Untested, I'd appreciate if you can test it.

[kkebo]

Thank you so much!

kkebo/swift-syntax's tests have passed.

#148

I'll trigger kkebo/swift-format's tests later too.

[kkebo]

kkebo/swift-format

• [DNM] test swiftlang/swift-syntax#2944 swift-format#221 (wasm32-unknown-wasi)
• [DNM] test swiftlang/swift-syntax#2944 (wasm32-unknown-wasip1-threads) swift-format#222 (wasm32-unknown-wasip1-threads)