Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with prefixIDs plugin not replacing url() refs correctly #908

Merged
merged 2 commits into from
Feb 19, 2018
Merged

Fix issue with prefixIDs plugin not replacing url() refs correctly #908

merged 2 commits into from
Feb 19, 2018

Commits on Feb 19, 2018

  1. Add failing test case for prefixIDs plugin 

    When using the prefixIDs plugin  on an svg with multiple linearGradients, url() values are not replaced correctly
    Harris P Jose committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    2ce1066 View commit details
    Browse the repository at this point in the history

  2. Fix issue with prefixIDs plugin not replacing url() values correctly 

    Global regexs must be reseted after every exec call since they preserve the last matched index. Since we use `css-url-regex`, creating a new regex before `exec`ing fixes this.
    Harris P Jose committed Feb 19, 2018
    Configuration menu
    Copy the full SHA
    40987c9 View commit details
    Browse the repository at this point in the history