Fix issue with prefixIDs plugin not replacing url() refs correctly #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 19, 2018 10:54
When using the prefixIDs plugin on an svg with multiple linearGradients, url() values are not replaced correctly
Global regexs must be reseted after every exec call since they preserve the last matched index. Since we use `css-url-regex`, creating a new regex before `exec`ing fixes this.
caub
approved these changes
Feb 19, 2018
|
@harrisjose: Good catch. There is an open issue about this in the css-url-regex module. |
|
@strarsis I thought I'd already looked in the css-url-regex module for this. Oh well. If there aren't any further changes required, can we get this merged and released? I'd really appreciate it cause we're running into this issue with a few svgs at work. Thanks. |
|
@GreLI |
|
@harrisjose done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the prefixIDs plugin on an SVG with multiple linear gradients, url() values are not replaced correctly because we use
execto capture values using the regex. Exec preserves the last matched index, which is undesirable in this case.Please ref this stackoverflow answer for more information about this.