Prevent spotbugs-annotations from transitively leaking as dependency #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ependency into other projects that use this project
scholzj
approved these changes
Oct 3, 2024
see-quick
approved these changes
Oct 3, 2024
Sorry, didn't notice this. But it was merged I see. Just for the record, consider it signed off ... Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change removes the need for other projects that package this dependency (e.g.
strimzi/strimzi-kafka-operator) to explicitly exclude thespotbug-annotationsfromkafka-quotas-plugindependency in their poms.spotbugs-annotationsis a test-time dependency, but due to the mechanics of how it operates it is declared as compile time dependency which causes it to be automatically transitively pulled in when this project is referenced as a dependency of another project. By making itprovidedscoped it is still present at compile time so it can perform its function during testing but it will not automatically be pulled into the using projects as a transitive dependency.