-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-18427: read central DB ID override from optional ConfigMap #1198
Conversation
Skipping CI for Draft Pull Request. |
dbc7fc2
to
f320661
Compare
f320661
to
d94244a
Compare
d94244a
to
cf41e21
Compare
cf41e21
to
fa417c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the override approach is more safe than relying on tags, so i'm fine with that. Just a minor thing about the comment.
At some point we probably want to integrate the DB ID override to the GitOps configuration. Could be worth creating a ticket for that.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johannes94, vladbologa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Currently the name of a Central DB is fixed and based on the Central's ID. E.g. for the ID
cjmugfm9rusboqitae5g
the DB cluster must be calledrhacs-cjmugfm9rusboqitae5g-db-cluster
.This PR gives the possibility to override the default naming scheme. For example, if the above DB is restored from backup into
rhacs-examplebackup-db-cluster
, then fleetshard-sync can be instructed to use the alternate name in the following way:kubectl create configmap central-db-override --namespace=rhacs-cjmugfm9rusboqitae5g --from-literal=databaseID=examplebackup
Checklist (Definition of Done)
Added test description underTest manual
Documentation added if necessary (i.e. changes to dev setup, test execution, ...)ROX-12345: ...
Discussed security and business related topics privately. Will move any security and business related topics that arise to private communication channel.Add secret to app-interface Vault or Secrets Manager if necessaryCheck AWS limits are reasonable for changes provisioning new resourcesTest manual
Tested E2E locally by creating a ConfigMap as described above and confirming that Central can connect to an overridden DB.