-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROX-18431: restore deleted tenant through API #1207
Merged
johannes94
merged 22 commits into
main
from
jmalsam/ROX-18431-restore-deleted-tenant-api
Sep 12, 2023
Merged
ROX-18431: restore deleted tenant through API #1207
johannes94
merged 22 commits into
main
from
jmalsam/ROX-18431-restore-deleted-tenant-api
Sep 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skipping CI for Draft Pull Request. |
johannes94
had a problem deploying
to
development
August 17, 2023 13:50
— with
GitHub Actions
Failure
johannes94
had a problem deploying
to
development
August 29, 2023 08:00
— with
GitHub Actions
Failure
johannes94
had a problem deploying
to
development
August 29, 2023 11:10
— with
GitHub Actions
Failure
johannes94
had a problem deploying
to
development
August 29, 2023 11:34
— with
GitHub Actions
Failure
johannes94
had a problem deploying
to
development
August 29, 2023 11:39
— with
GitHub Actions
Failure
johannes94
force-pushed
the
jmalsam/ROX-18431-restore-deleted-tenant-api
branch
from
September 5, 2023 06:41
de505af
to
9b6968e
Compare
johannes94
temporarily deployed
to
development
September 5, 2023 06:41
— with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
September 7, 2023 14:04
— with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
September 7, 2023 14:04
— with
GitHub Actions
Inactive
johannes94
force-pushed
the
jmalsam/ROX-18431-restore-deleted-tenant-api
branch
from
September 12, 2023 07:04
2e2d8bb
to
b3a23c7
Compare
johannes94
temporarily deployed
to
development
September 12, 2023 07:04
— with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
September 12, 2023 07:04
— with
GitHub Actions
Inactive
johannes94
temporarily deployed
to
development
September 12, 2023 07:04
— with
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds an API endpoint to the admin API of fleetmanager that allows to restore a deleted Central.
The restore operation resets the values of a deleted central in the database that are filled during the provisioning and deletion state machine flow. Then it resets it to provisioning and lets fleetshard-sync recreate the tenant. Additional logic in fleetshard-sync will search for RDS snapshots associated with cluster-id and restore the DB from a final snapshot if it exists.
The restore operation is currently limited, as it only restores the database to a state where the db password and master password needs to be restored. In order to get to a working tenant one has to follow: https://gitlab.cee.redhat.com/stackrox/acs-cloud-service/runbooks/-/blob/3c22117db0652ff52d54179038f625164d352f15/sops/dp-024-lost-tenant-db-password.md#L1
This PR will fix that: #1197
Checklist (Definition of Done)
Test manual
[ ] Documentation added if necessary (i.e. changes to dev setup, test execution, ...)Docs will be updated in SOP repo.ROX-12345: ...
Test manual
Tested on an OSD cluster with all integrations (Route53, AWS RDS Database, RH SSO)