Add group test vectors #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 25, 2023
mixmix
approved these changes
Oct 30, 2023
mixmix
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Where did these vectors come from?
One critique is that the Envelope Spec is not ssb-specific. So these vectors are not really in keeping with this repo, in that they have things like author fields which have to be mapped into a BFE (binary field encoding), the details of which are described be another spec (the private-groups-spec)
I think that spec is the better location for these... oh wait... they're already in that repo...
https://github.com/ssbc/private-group-spec/blob/master/vectors/unbox1.json
oh ... but those vectors are "modern" URI and these are "classic" sigil based.
Yeah I think making unbox1.classic.json in there seems like a good idea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For ssbc/ssb-tribes#102
Also a readme to more easily tell where there are tests using the vectors