Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unbox vectors #35

Closed
wants to merge 1 commit into from
Closed

Remove unbox vectors #35

wants to merge 1 commit into from

Conversation

Powersource
Copy link
Collaborator

For ssbc/ssb-tribes#102

We're moving them (or rather, and older version of them with sigil links instead of uris) from ssb-tribes to envelope-spec ssbc/envelope-spec#23

@Powersource Powersource mentioned this pull request Oct 25, 2023
Closed
6 tasks
@Powersource
Copy link
Collaborator Author

tests passing locally

mixmix
mixmix requested changes Oct 30, 2023
View reviewed changes
Copy link
Member

@mixmix mixmix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

disagree. Leave these vectors here please - they may be being depended on.
This repo can have both modern + classic vectors here for testing.

  • unbox1.json - has modern URI based ids
  • unbox1.classic.json the old sigil based ids

@mixmix mixmix closed this Oct 30, 2023
@mixmix mixmix deleted the remove-unbox-vectors branch October 30, 2023 08:12
@Powersource Powersource mentioned this pull request Nov 1, 2023
Merged
@Powersource
Copy link
Collaborator Author

new pr #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mixmix mixmix mixmix requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Powersource @mixmix