Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode url path segments & query parameters #4291

Merged
merged 3 commits into from
Jul 16, 2024
Merged

Encode url path segments & query parameters #4291

merged 3 commits into from
Jul 16, 2024

Conversation

NewAgeCZ
Copy link
Contributor

@NewAgeCZ NewAgeCZ commented Jul 15, 2024 •
edited
Loading

Rebased upon main, added author tag and edited date strings in licenses
New PR of the old #4163

  • Extend test suite with instanceId value that requires encoding
  • Fix url encoding in both RestTemplate & WebClient

@NewAgeCZ NewAgeCZ mentioned this pull request Jul 15, 2024
Closed
@OlgaMaciaszek OlgaMaciaszek self-assigned this Jul 16, 2024
@OlgaMaciaszek
Copy link
Collaborator

Fixes gh-4121.

OlgaMaciaszek
OlgaMaciaszek approved these changes Jul 16, 2024
View reviewed changes
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @NewAgeCZ. LGTM.

@OlgaMaciaszek OlgaMaciaszek merged commit 4956943 into spring-cloud:main Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlgaMaciaszek OlgaMaciaszek OlgaMaciaszek approved these changes

Assignees

@OlgaMaciaszek OlgaMaciaszek

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NewAgeCZ @OlgaMaciaszek @spring-cloud-issues