Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Encode url path segments & query parameters #4163

Closed
wants to merge 216 commits into from
Closed

Encode url path segments & query parameters #4163

wants to merge 216 commits into from

Conversation

NewAgeCZ
Copy link
Contributor

@NewAgeCZ NewAgeCZ commented Mar 5, 2023

  • Extend test suite with instanceId value that requires encoding
  • Fix url encoding in both RestTemplate & WebClient

spencergibb and others added 30 commits January 13, 2022 12:15
@spencergibb
Updates to version 4.0.0
fef3a9e 
Updates for java 17, framework 6, boot 3 and jakarta ee

Eureka still not compatible with jakarta ee
@spencergibb
Updates to version 4.0.0
2532e3a 
Updates for java 17, framework 6, boot 3 and jakarta ee

Eureka still not compatible with jakarta ee
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
e5ba257
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
e33e5a5
@OlgaMaciaszek
Upgrade wro4j-maven-plugin to 0.10.1. Fixes spring-cloudgh-4076.
2c22afa
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
fab3190
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
cdf8965
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
9391360
@weixsun
Fixes circleci (spring-cloud#4087)
2a31d0e
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
e38cd1e
@OlgaMaciaszek
Remove deprecated constructor.
27ac337
@OlgaMaciaszek
Fix @LocalServerPort imports.
9e1f7f6
Merge branch '3.1.x'
d831ca3
Fixing compilation error
b8af1db
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
3af988a
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
0188b25
@OlgaMaciaszek
Fix merge.
65fb24e
@spencergibb
Removes compile dependency on config server.
01c2c04 
Configures duplicate-finder-maven-plugin to ignore tests.
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
01f72ff
@OlgaMaciaszek
Merge remote-tracking branch 'origin/3.1.x'
67c227d
@spencergibb
Updates eureka to version 2.0.0-SNAPSHOT (spring-cloud#4120)
d0f8fbe 
* Updates eureka to version 2.0.0-SNAPSHOT

* Updates to renamed jersey3 modules and classes

* Removes unused import

* Adds netflix snapshot repository
@spencergibb
Migrates to new AutoConfiguration.imports
4c77b6d
@spencergibb
Adds / path mapping to test
dff98c4
@spencergibb
removes unused tests
4f2ddfd
@spencergibb
Disables test
3a91f23
@spencergibb
Fixes test assertion
6316953
@spencergibb
injects OptionalArgs
f76de4c
@spencergibb
Migrates to new AutoConfiguration.imports
a3cfba7
@spring-builds
Bumping versions
09adda6
@spencergibb
Upgrade to 2.0.0-rc.3
e8976ae 
Fixes spring-cloudgh-4122
@krezovic krezovic mentioned this pull request May 5, 2024
Merged
OlgaMaciaszek and others added 14 commits May 16, 2024 12:01
@OlgaMaciaszek
Upgrade antora-ui-spring to 0.4.13.
307b93b
@spring-builds
Update SNAPSHOT to 4.1.2
aa45392
@spring-builds
Going back to snapshots
5597c57
@spring-builds
Bumping versions to 4.1.3-SNAPSHOT after release
24716c6
@ryanjbaxter
Upgrading antora
1e2f6ee
@dependabot
Bump testcontainers.version from 1.19.7 to 1.19.8 (spring-cloud#4282)
bf6dafe 
Bumps `testcontainers.version` from 1.19.7 to 1.19.8.

Updates `org.testcontainers:mockserver` from 1.19.7 to 1.19.8
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.19.7...1.19.8)

Updates `org.testcontainers:junit-jupiter` from 1.19.7 to 1.19.8
- [Release notes](https://github.com/testcontainers/testcontainers-java/releases)
- [Changelog](https://github.com/testcontainers/testcontainers-java/blob/main/CHANGELOG.md)
- [Commits](testcontainers/testcontainers-java@1.19.7...1.19.8)

---
updated-dependencies:
- dependency-name: org.testcontainers:mockserver
  dependency-type: direct:development
  update-type: version-update:semver-patch
- dependency-name: org.testcontainers:junit-jupiter
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@kaiyaok2
Fixed non-idempotent test ConfigRefreshTests.verifyGetApplications (s…
f47e93c 
…pring-cloud#4279)
@OlgaMaciaszek
Handle TLS settings for Eureka Server's JerseyClient. (spring-cloud#4285
b43fa21 
)
@OlgaMaciaszek
Upgrade Eureka to 2.0.3.
702c10d
@dependabot
Bump org.glassfish.hk2:spring-bridge from 3.1.0 to 3.1.1 (spring-clou…
aa0670b 
…d#4289)

Bumps [org.glassfish.hk2:spring-bridge](https://github.com/eclipse-ee4j/glassfish-hk2) from 3.1.0 to 3.1.1.
- [Release notes](https://github.com/eclipse-ee4j/glassfish-hk2/releases)
- [Changelog](https://github.com/eclipse-ee4j/glassfish-hk2/blob/master/CHANGELOG)
- [Commits](https://github.com/eclipse-ee4j/glassfish-hk2/commits)

---
updated-dependencies:
- dependency-name: org.glassfish.hk2:spring-bridge
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@OlgaMaciaszek
Allow disabling the under the hood use of JerseyClient with Eureka Cl…
b23c587 
…ient. Fixes spring-cloudgh-4185.
@spring-builds
Update SNAPSHOT to 4.1.3
91ef811
@spring-builds
Going back to snapshots
a3840db
@spring-builds
Bumping versions to 4.1.4-SNAPSHOT after release
9f75748
@OlgaMaciaszek OlgaMaciaszek self-assigned this Jul 15, 2024
OlgaMaciaszek
OlgaMaciaszek requested changes Jul 15, 2024
View reviewed changes
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NewAgeCZ, thanks for the PR. It seems we must have overlooked it (most probably since it targets 3.1.x that's been out of maintenance for quite some time). Sorry for this.

Looks good, however, can you please resubmit these changes against the main branch? Also. please add your full name and surname with the @author tag to the javadocs of all the classes you've modified, and also update the date Strings in the license comments on top of the modified classes to -2024 if not done already.

@OlgaMaciaszek
Copy link
Collaborator

Fixes gh-4121.

@NewAgeCZ NewAgeCZ force-pushed the fix/3.1.x/urlencoding branch from 624ed49 to 5eacda7 Compare July 15, 2024 19:52
@NewAgeCZ NewAgeCZ mentioned this pull request Jul 15, 2024
Merged
@NewAgeCZ
Copy link
Contributor Author

Hi @OlgaMaciaszek , apologies, I had done fixes to both 3.1.x and main and mismatched the branches.

Closing this now, please continue at #4291

@NewAgeCZ NewAgeCZ closed this Jul 15, 2024
@NewAgeCZ NewAgeCZ deleted the fix/3.1.x/urlencoding branch July 15, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlgaMaciaszek OlgaMaciaszek OlgaMaciaszek requested changes

Assignees

@OlgaMaciaszek OlgaMaciaszek

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.