Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Event sender engine #88
feat: Event sender engine #88
Changes from 6 commits
384c23c
843cc0b
dbd94e4
00c233a
322da37
feaaa71
7c12583
033b8e9
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 52 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 57 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 60 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 61 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 65 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 67 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 68 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 70 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 85 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
Check warning on line 87 in Sources/Confidence/EventSenderEngine.swift
GitHub Actions / SwiftLint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about test cases and what do you think about something pseudo like this:
We don't have support for this yet but I think we need it (on both android and ios).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you mean introducing flush intervals?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes 👍 but for later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ticket is created here