feat: Event sender engine #88
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vahidlazio
force-pushed
the
event-sender-engine
branch
from
a2d0abd to
00c233a
Compare
vahidlazio
force-pushed
the
event-sender-engine
branch
6 times, most recently
from
76bff37 to
5269c87
Compare
vahidlazio
force-pushed
the
event-sender-engine
branch
from
5269c87 to
feaaa71
Compare
vahidlazio
requested review from
fabriziodemaria,
mfranberg,
nicklasl and
nickybondarenko
as code owners
nicklasl
reviewed
Apr 11, 2024
nicklasl
reviewed
Apr 11, 2024
nicklasl
reviewed
Apr 11, 2024
nicklasl
reviewed
Apr 11, 2024
|
|
||
| } | ||
|
|
||
| final class EventSenderEngineTest: XCTestCase { |
There was a problem hiding this comment.
I was thinking about test cases and what do you think about something pseudo like this:
// given that engine is initialized with storage that contains 3 events to be uploaded
// when no "sends" happen (in some specific time?)
// expect the 3 events to be uploaded
We don't have support for this yet but I think we need it (on both android and ios).
There was a problem hiding this comment.
you mean introducing flush intervals?
There was a problem hiding this comment.
Ticket is created here
nicklasl
approved these changes
Apr 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.