refactor: Restrict heterogeneous ConfidenceValue lists #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabriziodemaria
changed the title
fabriziodemaria
commented
Apr 4, 2024
Comment on lines
+33
to
+35
| public init(valueList: [ConfidenceValue]) { | ||
| self.value = .list(valueList.map { $0.value }) | ||
| } |
There was a problem hiding this comment.
Here we could make this private (or delete this), but then the problem is how to convert heterogeneous Values from OpenFeature
There was a problem hiding this comment.
I think it would be nicer to have multiple inits:
public init(valueList: [String]) {}
public init(valueList: [Int64]) {}
public init(valueList: [Bool]) {}
...
nicklasl
approved these changes
Apr 4, 2024
fabriziodemaria
requested review from
mfranberg,
vahidlazio and
nickybondarenko
as code owners
fabriziodemaria
added a commit
that referenced
this pull request
Apr 9, 2024
* Add ConfidenceValue * Add ConfidenceValueTests * Remove DateComponents * Simplify and finalize ConfidenceValue * Test fix * Update demo app * Variable renaming * ConfidenceValue is only Codable * Add Confidence-OF converstions * refactor: Restrict heterogeneous ConfidenceValue lists (#86) * Change ConfidenceValue constructors for more control * Setup for list restrictions * Remove unused converters * Change time-related arg labels * Fix date format * Explicit UTC settings and TZ tests * Best effort convert OF lists * Rename bool to boolean * Rename TZ offset from timestamps * Add swiftpm back
nickybondarenko
pushed a commit
that referenced
this pull request
Apr 10, 2024
* Add ConfidenceValue * Add ConfidenceValueTests * Remove DateComponents * Simplify and finalize ConfidenceValue * Test fix * Update demo app * Variable renaming * ConfidenceValue is only Codable * Add Confidence-OF converstions * refactor: Restrict heterogeneous ConfidenceValue lists (#86) * Change ConfidenceValue constructors for more control * Setup for list restrictions * Remove unused converters * Change time-related arg labels * Fix date format * Explicit UTC settings and TZ tests * Best effort convert OF lists * Rename bool to boolean * Rename TZ offset from timestamps * Add swiftpm back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exploratory PR not meant for merging yet.